Bug 222068

Summary: DumpRenderTree's createWebViewAndOffscreenWindow() should return a RetainPtr
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cmarcelo, darin, ews-watchlist, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 222009    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-02-17 14:09:48 PST
DumpRenderTree's createWebViewAndOffscreenWindow() should return a RetainPtr.
Attachments
Patch (5.16 KB, patch)
2021-02-17 14:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-02-17 14:10:54 PST
Created attachment 420711 [details] Patch
EWS
Comment 2 2021-02-17 16:24:58 PST
Committed r273046: <https://commits.webkit.org/r273046> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420711 [details].
Radar WebKit Bug Importer
Comment 3 2021-02-17 16:25:43 PST
<rdar://problem/74454987>
Darin Adler
Comment 4 2021-02-17 16:28:14 PST
Comment on attachment 420711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420711&action=review > Source/WTF/wtf/Forward.h:74 > +#if USE(CF) || defined(__OBJC__) Not sure we need the conditional; I don’t think it does harm to have this declaration on platforms where it doesn’t exist. > Source/WTF/wtf/Forward.h:146 > +#if USE(CF) || defined(__OBJC__) Ditto.
Chris Dumez
Comment 5 2021-02-17 18:27:12 PST
(In reply to Darin Adler from comment #4) > Comment on attachment 420711 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420711&action=review > > > Source/WTF/wtf/Forward.h:74 > > +#if USE(CF) || defined(__OBJC__) > > Not sure we need the conditional; I don’t think it does harm to have this > declaration on platforms where it doesn’t exist. > > > Source/WTF/wtf/Forward.h:146 > > +#if USE(CF) || defined(__OBJC__) > > Ditto. Ok. I followed up with <https://commits.webkit.org/r273056>.
Note You need to log in before you can comment on or make changes to this bug.