Bug 222046

Summary: [Cocoa] Web Inspector: add support for using custom process pool and page group identifier
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1.0
none
Patch v1.1
none
Patch v1.2 timothy: review+, bburg: commit-queue-

Blaze Burg
Reported 2021-02-17 09:05:19 PST
<rdar://74180162>
Attachments
Patch v1.0 (25.21 KB, patch)
2021-02-17 16:54 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v1.1 (22.12 KB, patch)
2021-02-17 23:59 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v1.2 (20.91 KB, patch)
2021-02-18 09:58 PST, Blaze Burg 		timothy: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2021-02-17 16:54:55 PST
Created attachment 420761 [details] Patch v1.0
Blaze Burg
Comment 2 2021-02-17 23:59:24 PST
Created attachment 420801 [details] Patch v1.1
Blaze Burg
Comment 3 2021-02-18 09:47:20 PST
3 GTK API tests are failing, which looks relevant: Unexpected timeouts (3) /WebKit2Gtk/TestInspector /webkit/WebKitWebInspector/custom-container-destroyed /webkit/WebKitWebInspector/manual-attach-detach /webkit/WebKitWebInspector/default
Blaze Burg
Comment 4 2021-02-18 09:49:52 PST
Comment on attachment 420801 [details] Patch v1.1 View in context: https://bugs.webkit.org/attachment.cgi?id=420801&action=review > Source/WebKit/UIProcess/Inspector/WebInspectorUtilities.cpp:-85 > - // Do not delay process launch for inspector pages as inspector pages do not know how to transition from a terminated process. I'm pretty sure that this call was lost for non-Mac ports, so I'm going to duplicate it here and in the custom pools code path in WKInspectorViewController.
Blaze Burg
Comment 5 2021-02-18 09:58:26 PST
Created attachment 420838 [details] Patch v1.2
Blaze Burg
Comment 6 2021-02-18 16:09:48 PST
Committed r273109 (234306@main): <https://commits.webkit.org/234306@main>
Note You need to log in before you can comment on or make changes to this bug.