Bug 222041

Summary: Enable MEDIA_SOURCE in IOS Simulator
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, calvaris, cdumez, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing ews-feeder: commit-queue-

youenn fablet
Reported 2021-02-17 07:43:24 PST
Enable MEDIA_SOURCE in IOS Simulator
Attachments
Patch (10.15 KB, patch)
2021-02-17 07:53 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (11.29 KB, patch)
2021-02-17 08:44 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.09 KB, patch)
2021-02-18 01:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.94 KB, patch)
2021-02-19 01:38 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (21.58 KB, patch)
2021-02-19 04:28 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (24.52 KB, patch)
2021-03-01 07:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.51 KB, patch)
2021-03-02 02:58 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-02-17 07:53:14 PST
Created attachment 420648 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-02-17 07:54:08 PST
<rdar://problem/74433510>
youenn fablet
Comment 3 2021-02-17 08:44:19 PST
Created attachment 420652 [details] Patch
youenn fablet
Comment 4 2021-02-18 01:48:28 PST
Created attachment 420809 [details] Patch
Eric Carlson
Comment 5 2021-02-18 08:32:29 PST
Comment on attachment 420809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420809&action=review > LayoutTests/ChangeLog:9 > + * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: It is probably worth mentioning why this has changed.
youenn fablet
Comment 6 2021-02-19 00:50:38 PST
imported/w3c/web-platform-tests/html/dom/idlharness.https.html is crashing in iOS sim debug since getAVStreamDataParserClass() returns nullptr. I'll update the patch to disable MSE in WebKitTestRunner for now. It would be good to fix this though.
youenn fablet
Comment 7 2021-02-19 01:38:44 PST
Created attachment 420940 [details] Patch
youenn fablet
Comment 8 2021-02-19 04:28:36 PST
Created attachment 420955 [details] Patch
youenn fablet
Comment 9 2021-02-19 05:56:28 PST
Comment on attachment 420955 [details] Patch Redoing a round of review since patch changed a bit
youenn fablet
Comment 10 2021-03-01 07:24:21 PST
Created attachment 421821 [details] Patch
Eric Carlson
Comment 11 2021-03-01 09:25:22 PST
Comment on attachment 421821 [details] Patch r=me once the bots are happy
youenn fablet
Comment 12 2021-03-01 11:28:12 PST
Comment on attachment 421821 [details] Patch Oh, didn't see Eric comment
youenn fablet
Comment 13 2021-03-02 02:58:00 PST
Created attachment 421918 [details] Patch for landing
EWS
Comment 14 2021-03-02 07:37:28 PST
Committed r273730: <https://commits.webkit.org/r273730> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421918 [details].
Alex Christensen
Comment 15 2021-03-05 08:10:23 PST
r273968
Note You need to log in before you can comment on or make changes to this bug.