Summary: | Animated keyframe style needs to go through full style adjuster | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | Animations | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, graouts, simon.fraser, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2021-02-17 05:23:15 PST
Created attachment 420632 [details]
wip
Created attachment 420642 [details]
patch
Comment on attachment 420642 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=420642&action=review > Source/WebCore/style/StyleAdjuster.cpp:-589 > - bool elementRespectsZIndex = style.position() != PositionType::Static || (parentBoxStyle && parentBoxStyle->isDisplayFlexibleOrGridBox()); > - > - if (elementRespectsZIndex && !style.hasAutoSpecifiedZIndex()) > - style.setUsedZIndex(style.specifiedZIndex()); > - else if (impact.contains(AnimationImpact::ForcesStackingContext)) I assume this is taken care of in Adjuster::adjust() now. > Source/WebCore/style/StyleAdjuster.h:49 > + void adjustAnimatedStyle(RenderStyle&, OptionSet<AnimationImpact>); const? Created attachment 420651 [details]
patch
> I assume this is taken care of in Adjuster::adjust() now. Yeah, ChangeLog even mentions it. > const? Good point! Committed r273003: <https://commits.webkit.org/r273003> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420651 [details]. *** Bug 221994 has been marked as a duplicate of this bug. *** |