Bug 222036

Summary: Animated keyframe style needs to go through full style adjuster
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: AnimationsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip
none
patch
zalan: review+
patch none

Antti Koivisto
Reported 2021-02-17 05:23:15 PST
You can make weird styles.
Attachments
wip (3.22 KB, patch)
2021-02-17 05:24 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (6.56 KB, patch)
2021-02-17 07:22 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (6.63 KB, patch)
2021-02-17 08:35 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-02-17 05:24:24 PST
Created attachment 420632 [details] wip
Antti Koivisto
Comment 2 2021-02-17 07:03:04 PST
rdar://72421747
Antti Koivisto
Comment 3 2021-02-17 07:22:02 PST
Created attachment 420642 [details] patch
alan
Comment 4 2021-02-17 08:27:17 PST
Comment on attachment 420642 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=420642&action=review > Source/WebCore/style/StyleAdjuster.cpp:-589 > - bool elementRespectsZIndex = style.position() != PositionType::Static || (parentBoxStyle && parentBoxStyle->isDisplayFlexibleOrGridBox()); > - > - if (elementRespectsZIndex && !style.hasAutoSpecifiedZIndex()) > - style.setUsedZIndex(style.specifiedZIndex()); > - else if (impact.contains(AnimationImpact::ForcesStackingContext)) I assume this is taken care of in Adjuster::adjust() now. > Source/WebCore/style/StyleAdjuster.h:49 > + void adjustAnimatedStyle(RenderStyle&, OptionSet<AnimationImpact>); const?
Antti Koivisto
Comment 5 2021-02-17 08:35:37 PST
Created attachment 420651 [details] patch
Antti Koivisto
Comment 6 2021-02-17 08:36:08 PST
> I assume this is taken care of in Adjuster::adjust() now. Yeah, ChangeLog even mentions it. > const? Good point!
EWS
Comment 7 2021-02-17 09:27:27 PST
Committed r273003: <https://commits.webkit.org/r273003> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420651 [details].
alan
Comment 8 2021-02-17 12:34:16 PST
*** Bug 221994 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.