Bug 222036

Summary: Animated keyframe style needs to go through full style adjuster
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: AnimationsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip
none
patch
zalan: review+
patch none

Description Antti Koivisto 2021-02-17 05:23:15 PST 
You can make weird styles.
Comment 1 Antti Koivisto 2021-02-17 05:24:24 PST 
Created attachment 420632 [details]
wip
Comment 2 Antti Koivisto 2021-02-17 07:03:04 PST 
rdar://72421747
Comment 3 Antti Koivisto 2021-02-17 07:22:02 PST 
Created attachment 420642 [details]
patch
Comment 4 zalan 2021-02-17 08:27:17 PST 
Comment on attachment 420642 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420642&action=review

> Source/WebCore/style/StyleAdjuster.cpp:-589
> -    bool elementRespectsZIndex = style.position() != PositionType::Static || (parentBoxStyle && parentBoxStyle->isDisplayFlexibleOrGridBox());
> -
> -    if (elementRespectsZIndex && !style.hasAutoSpecifiedZIndex())
> -        style.setUsedZIndex(style.specifiedZIndex());
> -    else if (impact.contains(AnimationImpact::ForcesStackingContext))

I assume this is taken care of in Adjuster::adjust() now.

> Source/WebCore/style/StyleAdjuster.h:49
> +    void adjustAnimatedStyle(RenderStyle&, OptionSet<AnimationImpact>);

const?
Comment 5 Antti Koivisto 2021-02-17 08:35:37 PST 
Created attachment 420651 [details]
patch
Comment 6 Antti Koivisto 2021-02-17 08:36:08 PST 
> I assume this is taken care of in Adjuster::adjust() now.

Yeah, ChangeLog even mentions it.

> const?

Good point!
Comment 7 EWS 2021-02-17 09:27:27 PST 
Committed r273003: <https://commits.webkit.org/r273003>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420651 [details].
Comment 8 zalan 2021-02-17 12:34:16 PST 
*** Bug 221994 has been marked as a duplicate of this bug. ***