Bug 222022

Summary: [iOS] Add support for additional accessibility image extraction contextmenu actions
Product: WebKit Reporter: Devin Rousso <hi>
Component: PlatformAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2021-02-16 19:57:26 PST
.
Attachments
Patch (3.55 KB, patch)
2021-02-16 19:58 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-02-16 19:57:50 PST
<rdar://problem/74157750>
Devin Rousso
Comment 2 2021-02-16 19:58:35 PST
Created attachment 420584 [details] Patch
Tim Horton
Comment 3 2021-02-16 20:45:25 PST
Comment on attachment 420584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420584&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9718 > +static NSMutableArray<UIMenuElement *> *menuElementsFromDefaultActions(const RetainPtr<NSArray>& defaultElementActions, RetainPtr<_WKActivatedElementInfo> elementInfo) For some reason I can't expand the context, is the return value really already a mutable array? (since you only change the type here)
Devin Rousso
Comment 4 2021-02-16 20:55:37 PST
Comment on attachment 420584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420584&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9718 >> +static NSMutableArray<UIMenuElement *> *menuElementsFromDefaultActions(const RetainPtr<NSArray>& defaultElementActions, RetainPtr<_WKActivatedElementInfo> elementInfo) > > For some reason I can't expand the context, is the return value really already a mutable array? (since you only change the type here) Yes the return value (after the `nil` on :9721) is an `NSMutableArray`.
EWS
Comment 5 2021-02-17 09:37:00 PST
Committed r273007: <https://commits.webkit.org/r273007> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420584 [details].
Note You need to log in before you can comment on or make changes to this bug.