Bug 221959

Summary: [iOS] Remove access to the Mobile asset service
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch none

Per Arne Vollan
Reported 2021-02-16 06:32:49 PST
Remove access to the Mobile asset service in the WebContent process, since there are no longer reports of this being in use.
Attachments
Patch (7.42 KB, patch)
2021-02-16 06:42 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (7.39 KB, patch)
2021-02-16 10:20 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (7.72 KB, patch)
2021-02-16 10:34 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-02-16 06:38:27 PST
<rdar://73362858>
Per Arne Vollan
Comment 2 2021-02-16 06:42:24 PST
Created attachment 420468 [details] Patch
Brent Fulgham
Comment 3 2021-02-16 10:07:58 PST
Comment on attachment 420468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420468&action=review It looks like this patch is out-of-date now. Can you regenerate so EWS can use it? > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-717 > - (global-name "com.apple.mobileassetd" "com.apple.mobileassetd.v2")) I guess we don't need to keep "mobleassetd.v2" because it is picked up by the dynamic case when Reader mode is used?
Per Arne Vollan
Comment 4 2021-02-16 10:20:59 PST
Created attachment 420492 [details] Patch
Per Arne Vollan
Comment 5 2021-02-16 10:22:18 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 420468 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420468&action=review > > It looks like this patch is out-of-date now. Can you regenerate so EWS can > use it? > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-717 > > - (global-name "com.apple.mobileassetd" "com.apple.mobileassetd.v2")) > > I guess we don't need to keep "mobleassetd.v2" because it is picked up by > the dynamic case when Reader mode is used? Yes. Thanks for reviewing!
Brent Fulgham
Comment 6 2021-02-16 10:23:22 PST
Comment on attachment 420492 [details] Patch r=me
Brent Fulgham
Comment 7 2021-02-16 10:23:40 PST
Comment on attachment 420492 [details] Patch r=me
Per Arne Vollan
Comment 8 2021-02-16 10:34:30 PST
Created attachment 420496 [details] Patch
Per Arne Vollan
Comment 9 2021-02-16 18:09:46 PST
Comment on attachment 420496 [details] Patch Thanks for reviewing!
EWS
Comment 10 2021-02-16 18:42:29 PST
Committed r272975: <https://commits.webkit.org/r272975> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420496 [details].
Note You need to log in before you can comment on or make changes to this bug.