Bug 221938

Summary: [iOS] the tracks button should be emphasized while the media controls context menu is showing
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hi, jer.noble, joepeck, kondapallykalyan, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 221937    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2021-02-15 17:01:45 PST
this would make it clearer what originated the contextmenu
Attachments
Patch (12.10 KB, patch)
2021-02-15 17:08 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (12.37 KB, patch)
2021-02-17 09:46 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-02-15 17:08:09 PST
Created attachment 420397 [details] Patch
Eric Carlson
Comment 2 2021-02-16 10:04:22 PST
Comment on attachment 420397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review > Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340 > + if (m_showMediaControlsContextMenuCallback) > + return false; If this condition is an error, it could be useful to have an ASSERT.
Devin Rousso
Comment 3 2021-02-17 09:45:12 PST
Comment on attachment 420397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review >> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340 >> + return false; > > If this condition is an error, it could be useful to have an ASSERT. This isn't an error condition. There's nothing to stop the user from tapping on the overflow button when the tracks contextmenu is already shown. This is a guard for that behavior.
Devin Rousso
Comment 4 2021-02-17 09:46:00 PST
Created attachment 420658 [details] Patch
EWS
Comment 5 2021-02-17 13:36:21 PST
Committed r273024: <https://commits.webkit.org/r273024> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420658 [details].
Radar WebKit Bug Importer
Comment 6 2021-02-17 13:37:16 PST
<rdar://problem/74447945>
Note You need to log in before you can comment on or make changes to this bug.