Bug 221924

Summary: Web Inspector: Add checkbox to toggle all grid overlays
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Mockup
none
Patch
none
[Video] With patch applied
none
Patch none

Description Nikita Vasilyev 2021-02-15 14:13:10 PST
Created attachment 420369 [details]
[Image] Mockup

I encountered that most of the time I want to show/hide all grid overlays at once.
It would be handy to have a global checkbox.

When some grids are on and some are off, the global checkbox should have a partial state:
[-] Grid Overlays:
[v] div.column
[ ] section.Copy

This can be achieved with:
```
checkboxElement.indeterminate = true;
```
Comment 1 Radar WebKit Bug Importer 2021-02-15 14:13:19 PST
<rdar://problem/74365101>
Comment 2 Nikita Vasilyev 2021-03-10 17:48:01 PST
Created attachment 422889 [details]
Patch
Comment 3 Nikita Vasilyev 2021-03-10 17:51:37 PST
Created attachment 422890 [details]
[Video] With patch applied
Comment 4 Nikita Vasilyev 2021-03-10 17:59:49 PST
Created attachment 422892 [details]
Patch

Rebaselined.
Comment 5 BJ Burg 2021-03-10 23:09:09 PST
Comment on attachment 422892 [details]
Patch

r=me
Comment 6 EWS 2021-03-10 23:28:54 PST
Committed r274268: <https://commits.webkit.org/r274268>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422892 [details].