Bug 221912

Summary:

[LayoutTests] Convert http/tests/websocket convert PHP to Python

Product:

WebKit

Reporter:

Chris Gambrell <cgambrell>

Component:

Tools / Tests

Assignee:

Chris Gambrell <cgambrell>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220749

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Gambrell

Reported 2021-02-15 11:28:34 PST

Replacing PHP with equivalent Python CGI scripts

Attachments
Patch (12.80 KB, patch) 2021-02-15 11:41 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (12.80 KB, patch) 2021-02-15 12:23 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (12.78 KB, patch) 2021-03-01 13:47 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-02-15 11:29:06 PST

<rdar://problem/74358196>

Chris Gambrell

Comment 2 2021-02-15 11:41:53 PST

Created attachment 420344 [details] Patch

Jonathan Bedard

Comment 3 2021-02-15 12:18:16 PST

Comment on attachment 420344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420344&action=review > LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py:17 > + 'Set-Cookie: "WK-websocket-test-httponly=0; expires={} GMT; Max-Age=0; HttpOnly\r\n\r\n' Looks to be missing a closing quotation

Chris Gambrell

Comment 4 2021-02-15 12:23:47 PST

Created attachment 420347 [details] Patch

Chris Gambrell

Comment 5 2021-02-15 12:24:07 PST

(In reply to Jonathan Bedard from comment #3) > Comment on attachment 420344 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420344&action=review > > > LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py:17 > > + 'Set-Cookie: "WK-websocket-test-httponly=0; expires={} GMT; Max-Age=0; HttpOnly\r\n\r\n' > > Looks to be missing a closing quotation Fixed in comment 4

Jonathan Bedard

Comment 6 2021-02-25 10:50:36 PST

Comment on attachment 420347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420347&action=review > LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py:11 > +exp_time = datetime.utcnow() - timedelta(hours=1) Shouldn't this be a +? > LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py:19 > + ) I would do the early return here and git rid of the "else". It makes the multi-line string confusing. > LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies.py:19 > + ) Again, I would do the early exit here and ditch the else statement entirely.

Chris Gambrell

Comment 7 2021-03-01 13:47:37 PST

Created attachment 421863 [details] Patch

EWS

Comment 8 2021-03-01 15:28:13 PST

Committed r273698: <https://commits.webkit.org/r273698> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421863 [details].

Note You need to log in before you can comment on or make changes to this bug.