Bug 221877

Summary: Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2021-02-14 13:43:27 PST
Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth.
Attachments
Patch (2.41 KB, patch)
2021-02-14 13:45 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2021-02-15 02:02 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2021-02-14 13:45:31 PST
Created attachment 420250 [details] Patch
Sergio Villar Senin
Comment 2 2021-02-15 01:46:45 PST
Comment on attachment 420250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420250&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:491 > + Optional<LayoutUnit> childOverrideWidth; Nit: override -> overriding (we have recently switched the naming)
Rob Buis
Comment 3 2021-02-15 02:02:21 PST
Created attachment 420286 [details] Patch
EWS
Comment 4 2021-02-15 03:05:54 PST
Committed r272846: <https://commits.webkit.org/r272846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420286 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-15 03:06:14 PST
<rdar://problem/74344028>
Note You need to log in before you can comment on or make changes to this bug.