Summary: | [GTK] Need new user agent quirk for Google Docs and Google Drive | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=219278 https://bugs.webkit.org/show_bug.cgi?id=142074 https://bugs.webkit.org/show_bug.cgi?id=222039 https://bugs.webkit.org/show_bug.cgi?id=222978 |
||||||||
Attachments: |
|
Description
Michael Catanzaro
2021-02-12 13:48:49 PST
(In reply to Michael Catanzaro from comment #0) > We will probably have to select a > fairly risky Firefox or Chrome quirk and hope for the best. See bug #215845 for what happened last time I tried a Firefox quirk.... As far as I can tell, Google Drive is no longer displaying unsupported browser warnings at all, except for Internet Explorer. That's a welcome change. I think it is a very recent change, because I tested it when creating the Internet Explorer quirk and determined it was really required. Anyway, I will remove our quirk for Google Drive. Even better news: it seems we no longer need to send our Google Docs quirk to accounts.youtube.com. That was previously required for the quirk to take effect, but now it's sufficient to limit the quirk to docs.google.com. I think that was actually our fault, not Google's: it was probably an artifact of bug #191858. This is a *huge* relief because it means that if our new quirk does break something in the future, the scope will be limited to only Google Docs: it shouldn't blow up youtube.com or mail.google.com or accounts.google.com, all of which has happened to us in the past. I discovered that a Chrome quirk seems to work on Google Docs without breaking anything. So for now, we can safely go with that. It's a risky quirk and could easily break in the future, but we don't have many options here. Created attachment 420386 [details]
Patch
It seems the unit tests is failing Oops, they have to be updated whenever changing user agent quirks and I forgot to do so. Created attachment 420471 [details]
Patch
Committed r272921: <https://commits.webkit.org/r272921> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420471 [details]. (In reply to Michael Catanzaro from comment #0) > """ > Google Docs won't support Internet Explorer after March 15th, 2021 Please > upgrade to a > supported browser > """ Note there is a time bomb on how long we have to release this change before users start to complain. Sorry about this, especially that I didn't notice until the day after the 2.30.5 release. :/ |