Bug 221798 – [build.webkit.org] commit identifier should show main instead of trunk

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

We added commit identifier on build.webkit.org in https://commits.webkit.org/r272743. e.g.: https://build.webkit.org/#/builders/43/builds/125

It says xxx@trunk, instead it would be better to say xxx@main (to maintain consistency with ews).

[Aakash Jain]

Created attachment 420074 [details]
Patch

[Alexey Proskuryakov]

Will either or both forms continue to work into the future indefinitely?

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #2)
> Will either or both forms continue to work into the future indefinitely?
I believe, yes (for both forms). Jonathan might know better. But I haven’t heard of any plan or any reason to discontinue them.

Typically trunk is for svn, and main is for git. So main is definitely going to continue to work into the future indefinitely.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #2)
> Will either or both forms continue to work into the future indefinitely?

Both forms will continue to work in anything derived from webkitscmpy (along with master). Notably, that is git-webkit and commits.webkit.org. The code that makes this work is not specific to the WebKit repository, it's a more general aliasing of common default branch names.

[EWS]

commit-queue failed to commit attachment 420074 [details] to WebKit repository. To retry, please set cq+ flag again.

[Aakash Jain]

5 minute timeout doesn't seems to be enough (for initial run to cache things) on windows bots, e.g.: https://build.webkit.org/#/builders/67/builds/197

[Aakash Jain]

Created attachment 420136 [details]
Patch

[EWS]

Committed r272785: <https://commits.webkit.org/r272785>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420136 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74280945>