RESOLVED FIXED 221798
[build.webkit.org] commit identifier should show main instead of trunk
https://bugs.webkit.org/show_bug.cgi?id=221798
Summary [build.webkit.org] commit identifier should show main instead of trunk
Aakash Jain
Reported 2021-02-11 17:59:16 PST
We added commit identifier on build.webkit.org in https://commits.webkit.org/r272743. e.g.: https://build.webkit.org/#/builders/43/builds/125 It says xxx@trunk, instead it would be better to say xxx@main (to maintain consistency with ews).
Attachments
Patch (3.48 KB, patch)
2021-02-11 18:00 PST, Aakash Jain
no flags
Patch (3.51 KB, patch)
2021-02-12 09:32 PST, Aakash Jain
no flags
Aakash Jain
Comment 1 2021-02-11 18:00:33 PST
Alexey Proskuryakov
Comment 2 2021-02-11 19:29:31 PST
Will either or both forms continue to work into the future indefinitely?
Aakash Jain
Comment 3 2021-02-11 19:48:59 PST
(In reply to Alexey Proskuryakov from comment #2) > Will either or both forms continue to work into the future indefinitely? I believe, yes (for both forms). Jonathan might know better. But I haven’t heard of any plan or any reason to discontinue them. Typically trunk is for svn, and main is for git. So main is definitely going to continue to work into the future indefinitely.
Jonathan Bedard
Comment 4 2021-02-12 08:49:08 PST
(In reply to Alexey Proskuryakov from comment #2) > Will either or both forms continue to work into the future indefinitely? Both forms will continue to work in anything derived from webkitscmpy (along with master). Notably, that is git-webkit and commits.webkit.org. The code that makes this work is not specific to the WebKit repository, it's a more general aliasing of common default branch names.
EWS
Comment 5 2021-02-12 09:12:42 PST
commit-queue failed to commit attachment 420074 [details] to WebKit repository. To retry, please set cq+ flag again.
Aakash Jain
Comment 6 2021-02-12 09:31:51 PST
5 minute timeout doesn't seems to be enough (for initial run to cache things) on windows bots, e.g.: https://build.webkit.org/#/builders/67/builds/197
Aakash Jain
Comment 7 2021-02-12 09:32:57 PST
EWS
Comment 8 2021-02-12 10:06:10 PST
Committed r272785: <https://commits.webkit.org/r272785> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420136 [details].
Radar WebKit Bug Importer
Comment 9 2021-02-12 10:07:18 PST
Note You need to log in before you can comment on or make changes to this bug.