Summary: | Web Inspector: "Show Extended Gridlines" option for grid overlay does not work | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick Angle <pangle> | ||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, nvasilyev, rcaliman, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 221556 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Patrick Angle
2021-02-11 13:31:51 PST
Created attachment 420049 [details]
Patch
Comment on attachment 420049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420049&action=review > Source/WebInspectorUI/ChangeLog:9 > + Replace all instances of "GridLines" (camelcase) with "Gridlines" > + to match the protocol naming. I feel like this should actually be the opposite. I think "GridLines" is more accurate here because you're drawing "lines for CSS grid contexts". Not to mention it would likely be a smaller/simpler patch :P Also, this shouldn't be problematic to update the protocol with a new name since we haven't included any of the grid related types/commands/events in any legacy protocols yet. Created attachment 420058 [details]
Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Comment on attachment 420058 [details]
Patch
r=me
Committed r272768: <https://commits.webkit.org/r272768> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420058 [details]. |