Bug 221760 – [WPE] event.ctrlKey and other are false in keydown event

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

This is the same than bug #221456 but for WPE.

[Manuel Rego Casasnovas]

Created attachment 420001 [details]
Patch

[Adrian Perez]

Comment on attachment 420001 [details]
Patch

Other than a nit about the wording in the comment below, patch looks good. 
Thanks!

View in context: https://bugs.webkit.org/attachment.cgi?id=420001&action=review

> Source/WebKit/Shared/libwpe/WebEventFactory.cpp:64
> +    // to behave similar to other platforms and other browsers under X (see http://crbug.com/127142#c8).

WPE itself does not strictly depend on X11; so I think it would be a bit more
appropriate to write something like “Handling of modifier masks in WPE is modelled
after after X. This code makes WPE […]” ?

[Manuel Rego Casasnovas]

Created attachment 420029 [details]
Patch

[Manuel Rego Casasnovas]

(In reply to Adrian Perez from comment #2)
> Comment on attachment 420001 [details]
> Patch
> 
> Other than a nit about the wording in the comment below, patch looks good. 
> Thanks!

Thanks for the review.

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420001&action=review
> 
> > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:64
> > +    // to behave similar to other platforms and other browsers under X (see http://crbug.com/127142#c8).
> 
> WPE itself does not strictly depend on X11; so I think it would be a bit more
> appropriate to write something like “Handling of modifier masks in WPE is
> modelled
> after after X. This code makes WPE […]” ?

Yeah you're right, modified that on the new version.

[EWS]

Committed r272771: <https://commits.webkit.org/r272771>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420029 [details].