RESOLVED FIXED 221760
[WPE] event.ctrlKey and other are false in keydown event 
https://bugs.webkit.org/show_bug.cgi?id=221760
Summary [WPE] event.ctrlKey and other are false in keydown event
Manuel Rego Casasnovas
Reported 2021-02-11 09:41:27 PST
This is the same than bug #221456 but for WPE.
Attachments
Patch (4.25 KB, patch)
2021-02-11 09:45 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (4.26 KB, patch)
2021-02-11 12:36 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2021-02-11 09:45:35 PST
Created attachment 420001 [details] Patch
Adrian Perez
Comment 2 2021-02-11 12:03:32 PST
Comment on attachment 420001 [details] Patch Other than a nit about the wording in the comment below, patch looks good. Thanks! View in context: https://bugs.webkit.org/attachment.cgi?id=420001&action=review > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:64 > + // to behave similar to other platforms and other browsers under X (see http://crbug.com/127142#c8). WPE itself does not strictly depend on X11; so I think it would be a bit more appropriate to write something like “Handling of modifier masks in WPE is modelled after after X. This code makes WPE […]” ?
Manuel Rego Casasnovas
Comment 3 2021-02-11 12:36:43 PST
Created attachment 420029 [details] Patch
Manuel Rego Casasnovas
Comment 4 2021-02-11 12:37:16 PST
(In reply to Adrian Perez from comment #2) > Comment on attachment 420001 [details] > Patch > > Other than a nit about the wording in the comment below, patch looks good. > Thanks! Thanks for the review. > View in context: > https://bugs.webkit.org/attachment.cgi?id=420001&action=review > > > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:64 > > + // to behave similar to other platforms and other browsers under X (see http://crbug.com/127142#c8). > > WPE itself does not strictly depend on X11; so I think it would be a bit more > appropriate to write something like “Handling of modifier masks in WPE is > modelled > after after X. This code makes WPE […]” ? Yeah you're right, modified that on the new version.
EWS
Comment 5 2021-02-11 21:43:57 PST
Committed r272771: <https://commits.webkit.org/r272771> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420029 [details].
Note You need to log in before you can comment on or make changes to this bug.