Bug 221743

Summary: [WebAuthn] Provide SPI to query local credentials
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2021-02-10 22:23:01 PST
Provide SPI to query local credentials.
Attachments
Patch (10.76 KB, patch)
2021-02-10 22:26 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (10.78 KB, patch)
2021-02-12 12:57 PST, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (10.94 KB, patch)
2021-02-12 16:56 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2021-02-10 22:23:15 PST
<rdar://problem/65849832>
Jiewen Tan
Comment 2 2021-02-10 22:26:54 PST
Created attachment 419945 [details] Patch
Jiewen Tan
Comment 3 2021-02-12 12:57:35 PST
Created attachment 420171 [details] Patch
Brent Fulgham
Comment 4 2021-02-12 14:06:04 PST
Comment on attachment 420171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420171&action=review r=me > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:165 > + (id)kSecClass: (id)kSecClassKey, It's a shame so many casts are needed, but it looks like that's typical. It looks like these are usually done as (__bridge id) in other code. > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:231 > + (id)kSecClass: (id)kSecClassKey, Suggest (__bridge id)
Jiewen Tan
Comment 5 2021-02-12 16:54:23 PST
Comment on attachment 420171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420171&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:165 >> + (id)kSecClass: (id)kSecClassKey, > > It's a shame so many casts are needed, but it looks like that's typical. > > It looks like these are usually done as (__bridge id) in other code. Fixed.
Jiewen Tan
Comment 6 2021-02-12 16:56:20 PST
Created attachment 420197 [details] Patch for landing
EWS
Comment 7 2021-02-12 17:40:47 PST
Committed r272826: <https://commits.webkit.org/r272826> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420197 [details].
Note You need to log in before you can comment on or make changes to this bug.