Bug 221724

Summary: [webkit-patch] Use identifiers when posting to bugzilla
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dean_johnson, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221764
https://bugs.webkit.org/show_bug.cgi?id=221829
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Jonathan Bedard 2021-02-10 15:33:30 PST 
webkit-patch should post identifier links instead of trac links. This will be an incremental process because identifiers need to be computed from revisions, so we can't just blindly replace revisions everywhere without understanding what they're being used for.
Comment 1 Radar WebKit Bug Importer 2021-02-10 15:33:54 PST 
<rdar://problem/74209525>
Comment 2 Jonathan Bedard 2021-02-10 15:39:40 PST 
Created attachment 419916 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-10 15:40:24 PST 
(In reply to Jonathan Bedard from comment #2)
> Created attachment 419916 [details]
> Patch

Might be worth considering separating the trac -> commits part of this change from the identifier part of this change.
Comment 4 Jonathan Bedard 2021-02-11 15:33:35 PST 
Created attachment 420054 [details]
Patch
Comment 5 Jonathan Bedard 2021-02-11 15:36:45 PST 
Created attachment 420055 [details]
Patch
Comment 6 Aakash Jain 2021-02-11 16:41:23 PST 
Comment on attachment 420055 [details]
Patch

rs=me
Comment 7 Jonathan Bedard 2021-02-11 16:43:08 PST 
(In reply to Aakash Jain from comment #6)
> Comment on attachment 420055 [details]
> Patch
> 
> rs=me

I will land this first thing tomorrow morning.
Comment 8 Jonathan Bedard 2021-02-12 09:19:35 PST 
Committed 192745@main: <https://commits.webkit.org/192745@main>
Comment 9 Jonathan Bedard 2021-02-12 09:29:00 PST 
(In reply to Jonathan Bedard from comment #8)
> Committed 192745@main: <https://commits.webkit.org/192745@main>

Should actually be 234018@main, <https://commits.webkit.org/192745@main>

Looking into what happened.
Comment 10 Jonathan Bedard 2021-02-12 09:47:28 PST 
Comment on attachment 420055 [details]
Patch

My local cache was corrupted....probably the fault of the unit testing in this change....looking into options to fix
Comment 11 Jonathan Bedard 2021-02-12 10:27:07 PST 
Reopening to attach new patch.
Comment 12 Jonathan Bedard 2021-02-12 10:27:09 PST 
Created attachment 420142 [details]
Patch
Comment 13 Dean Johnson 2021-02-12 10:32:24 PST 
Can we please post revision *and* identifier links? Revisions are still what we're using to talk about and work with WebKit changes, so this change would make it more difficult to think about them when working across other systems still using identifiers and bugzilla.
Comment 14 Aakash Jain 2021-02-12 10:40:04 PST 
rs=me
Comment 15 Jonathan Bedard 2021-02-12 11:05:52 PST 
Committed 234029@main: <https://commits.webkit.org/234029@main>