Bug 221709

Summary: Bubblewrap should determine which libdirs to bind properly
Product: WebKit Reporter: Nina Kolesa <nina>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
patch
none
better patch none

Nina Kolesa
Reported 2021-02-10 12:06:36 PST
On some 32-bit systems, webkitgtk with bubblewrap will not work as is, since glibc will direct its ld cache lookups through lib32 by default if it exists; if this path is not bound, the dynamic linker will fail to find the right libs. Right now the bubblewrap launcher unconditionally binds lib64. Therefore, it should be changed to conditionally bind either lib32 or lib64.
Attachments
patch (1.83 KB, patch)
2021-02-10 12:08 PST, Nina Kolesa 		no flags
DetailsFormatted DiffDiff
better patch (1.82 KB, patch)
2021-02-10 12:30 PST, Nina Kolesa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nina Kolesa
Comment 1 2021-02-10 12:08:32 PST
Created attachment 419884 [details] patch not sure what the best way to do preprocessor conditional check for 64-bit systems would be here; this should probably be robust (but ugly)
Nina Kolesa
Comment 2 2021-02-10 12:30:41 PST
Created attachment 419888 [details] better patch use a WTF macro to check the pointer size
EWS
Comment 3 2021-03-15 06:15:10 PDT
Committed r274417: <https://commits.webkit.org/r274417> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419888 [details].
Note You need to log in before you can comment on or make changes to this bug.