Bug 221707

Summary: Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Andres Gonzalez
Reported 2021-02-10 11:52:29 PST
Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
Attachments
Patch (17.59 KB, patch)
2021-02-10 11:53 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (18.20 KB, patch)
2021-02-10 12:06 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (18.05 KB, patch)
2021-02-11 11:43 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (18.00 KB, patch)
2021-03-03 10:49 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (18.00 KB, patch)
2021-03-03 10:56 PST, Andres Gonzalez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (18.00 KB, patch)
2021-03-03 11:55 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2021-02-10 11:53:54 PST
Created attachment 419878 [details] Patch
Andres Gonzalez
Comment 2 2021-02-10 12:06:44 PST
Created attachment 419883 [details] Patch
Andres Gonzalez
Comment 3 2021-02-11 11:43:25 PST
Created attachment 420016 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-02-17 11:53:12 PST
<rdar://problem/74443794>
Andres Gonzalez
Comment 5 2021-03-03 10:49:46 PST
Created attachment 422117 [details] Patch
chris fleizach
Comment 6 2021-03-03 10:50:56 PST
Comment on attachment 422117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422117&action=review > Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:96 > + if (!notificationName.isEmpty()) { we can probably do an early return here if (notificatioName.isEmpty()) return;
Andres Gonzalez
Comment 7 2021-03-03 10:56:47 PST
Created attachment 422122 [details] Patch
Andres Gonzalez
Comment 8 2021-03-03 11:55:35 PST
Created attachment 422132 [details] Patch
EWS
Comment 9 2021-03-03 18:31:22 PST
Committed r273869: <https://commits.webkit.org/r273869> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422132 [details].
Note You need to log in before you can comment on or make changes to this bug.