Bug 221707

Summary: Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Andres Gonzalez 2021-02-10 11:52:29 PST 
Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
Comment 1 Andres Gonzalez 2021-02-10 11:53:54 PST 
Created attachment 419878 [details]
Patch
Comment 2 Andres Gonzalez 2021-02-10 12:06:44 PST 
Created attachment 419883 [details]
Patch
Comment 3 Andres Gonzalez 2021-02-11 11:43:25 PST 
Created attachment 420016 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-02-17 11:53:12 PST 
<rdar://problem/74443794>
Comment 5 Andres Gonzalez 2021-03-03 10:49:46 PST 
Created attachment 422117 [details]
Patch
Comment 6 chris fleizach 2021-03-03 10:50:56 PST 
Comment on attachment 422117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422117&action=review

> Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:96
> +    if (!notificationName.isEmpty()) {

we can probably do an early return here

if (notificatioName.isEmpty())
    return;
Comment 7 Andres Gonzalez 2021-03-03 10:56:47 PST 
Created attachment 422122 [details]
Patch
Comment 8 Andres Gonzalez 2021-03-03 11:55:35 PST 
Created attachment 422132 [details]
Patch
Comment 9 EWS 2021-03-03 18:31:22 PST 
Committed r273869: <https://commits.webkit.org/r273869>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422132 [details].