Bug 221707 - Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
Summary: Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification met...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 11:52 PST by Andres Gonzalez
Modified: 2021-03-03 18:31 PST (History)
9 users (show)

See Also:

Attachments
Patch (17.59 KB, patch)
2021-02-10 11:53 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (18.20 KB, patch)
2021-02-10 12:06 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (18.05 KB, patch)
2021-02-11 11:43 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2021-03-03 10:49 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2021-03-03 10:56 PST, Andres Gonzalez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2021-03-03 11:55 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-02-10 11:52:29 PST 
Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
Comment 1 Andres Gonzalez 2021-02-10 11:53:54 PST 
Created attachment 419878 [details]
Patch
Comment 2 Andres Gonzalez 2021-02-10 12:06:44 PST 
Created attachment 419883 [details]
Patch
Comment 3 Andres Gonzalez 2021-02-11 11:43:25 PST 
Created attachment 420016 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-02-17 11:53:12 PST 
<rdar://problem/74443794>
Comment 5 Andres Gonzalez 2021-03-03 10:49:46 PST 
Created attachment 422117 [details]
Patch
Comment 6 chris fleizach 2021-03-03 10:50:56 PST 
Comment on attachment 422117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422117&action=review

> Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:96
> +    if (!notificationName.isEmpty()) {

we can probably do an early return here

if (notificatioName.isEmpty())
    return;
Comment 7 Andres Gonzalez 2021-03-03 10:56:47 PST 
Created attachment 422122 [details]
Patch
Comment 8 Andres Gonzalez 2021-03-03 11:55:35 PST 
Created attachment 422132 [details]
Patch
Comment 9 EWS 2021-03-03 18:31:22 PST 
Committed r273869: <https://commits.webkit.org/r273869>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422132 [details].