Bug 221677

Summary: Rework RGB color types to be more declarative to reduce code duplication and make progress toward better automatic conversion
Product: WebKit Reporter: Sam Weinig <sam>
Component: PlatformAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-02-10 08:47:04 PST
Rework RGB color types to be more declarative to reduce code duplication and make progress toward better automatic conversion.
Attachments
Patch (73.41 KB, patch)
2021-02-10 11:14 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (73.26 KB, patch)
2021-02-10 17:20 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-02-10 11:14:10 PST Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-02-10 17:20:05 PST
Created attachment 419927 [details] Patch
Darin Adler
Comment 3 2021-02-11 08:15:52 PST
Comment on attachment 419927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419927&action=review > Source/WebCore/ChangeLog:48 > + more places now, and the deduction guides we had been using don't work, so we must explicitly specify A little sad to lose the deduction guides. > Source/WebCore/ChangeLog:54 > + intend to remove in a previous patch, but I am not actual sure is necessary. While I work that out, Even though I am the one who pointed it out, I think it’s not necessary.
Sam Weinig
Comment 4 2021-02-11 08:31:58 PST
(In reply to Darin Adler from comment #3) > Comment on attachment 419927 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419927&action=review > > > Source/WebCore/ChangeLog:48 > > + more places now, and the deduction guides we had been using don't work, so we must explicitly specify > > A little sad to lose the deduction guides. Me too, though I think it is the right tradeoff for the time being. I believe c++20 fixes this. Interestingly, it is the same paper that fixes the inherited constructor issue I noted in a previous patch - http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1021r5.html (I seem to running up against the limits of modern c++ :) ).
EWS
Comment 5 2021-02-11 08:36:36 PST
Committed r272731: <https://commits.webkit.org/r272731> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419927 [details].
Radar WebKit Bug Importer
Comment 6 2021-02-11 08:37:15 PST
<rdar://problem/74235403>
Note You need to log in before you can comment on or make changes to this bug.