Bug 221615

Summary: [LFC][IFC] Disable BIDI processing for modern line layout
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description zalan 2021-02-09 10:30:37 PST
We don't support BIDI content yet.
Comment 1 zalan 2021-02-09 10:34:41 PST
Created attachment 419739 [details]
Patch
Comment 2 Sam Weinig 2021-02-09 10:58:26 PST
Comment on attachment 419739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419739&action=review

> Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp:45
> +#define PRCOCESS_BIDI_CONTENT 0

Typo. PRCOCESS_BIDI_CONTENT -> PROCESS_BIDI_CONTENT.

Traditionally these go in PlatformEnable.h.
Comment 3 zalan 2021-02-09 11:01:13 PST
(In reply to Sam Weinig from comment #2)
> Comment on attachment 419739 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419739&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp:45
> > +#define PRCOCESS_BIDI_CONTENT 0
> 
> Typo. PRCOCESS_BIDI_CONTENT -> PROCESS_BIDI_CONTENT.
> 
> Traditionally these go in PlatformEnable.h.
This is very temporary (I could just remove the code as well).
Comment 4 zalan 2021-02-09 11:03:06 PST
Created attachment 419744 [details]
Patch
Comment 5 EWS 2021-02-09 12:28:04 PST
Committed r272602: <https://commits.webkit.org/r272602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419744 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-10 14:29:52 PST
<rdar://problem/74206476>