Bug 221615 - [LFC][IFC] Disable BIDI processing for modern line layout
Summary: [LFC][IFC] Disable BIDI processing for modern line layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-09 10:30 PST by zalan
Modified: 2021-02-10 14:29 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2021-02-09 10:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.11 KB, patch)
2021-02-09 11:03 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-02-09 10:30:37 PST 
We don't support BIDI content yet.
Comment 1 zalan 2021-02-09 10:34:41 PST 
Created attachment 419739 [details]
Patch
Comment 2 Sam Weinig 2021-02-09 10:58:26 PST 
Comment on attachment 419739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419739&action=review

> Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp:45
> +#define PRCOCESS_BIDI_CONTENT 0

Typo. PRCOCESS_BIDI_CONTENT -> PROCESS_BIDI_CONTENT.

Traditionally these go in PlatformEnable.h.
Comment 3 zalan 2021-02-09 11:01:13 PST 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 419739 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419739&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp:45
> > +#define PRCOCESS_BIDI_CONTENT 0
> 
> Typo. PRCOCESS_BIDI_CONTENT -> PROCESS_BIDI_CONTENT.
> 
> Traditionally these go in PlatformEnable.h.
This is very temporary (I could just remove the code as well).
Comment 4 zalan 2021-02-09 11:03:06 PST 
Created attachment 419744 [details]
Patch
Comment 5 EWS 2021-02-09 12:28:04 PST 
Committed r272602: <https://commits.webkit.org/r272602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419744 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-10 14:29:52 PST 
<rdar://problem/74206476>