Bug 221613

Summary: Check if ENGINEERING_BUILD is defined before testing it
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebCore Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED WONTFIX    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, mcatanzaro, philipj, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221371
https://bugs.webkit.org/show_bug.cgi?id=221621
Attachments:
Description Flags
Patch mcatanzaro: commit-queue-

Michael Catanzaro
Reported 2021-02-09 10:08:52 PST
Small warning added in bug #221371: [1385/2409] Building CXX object Source...ources/UnifiedSource-950a39b6-10.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-10.cpp:2: ../../Source/WebCore/html/HTMLMediaElement.cpp:7159:5: warning: "ENGINEERING_BUILD" is not defined, evaluates to 0 [-Wundef] 7159 | #if ENGINEERING_BUILD || !defined(NDEBUG) | ^~~~~~~~~~~~~~~~~ Let's test if it's defined first.
Attachments
Patch (1.47 KB, patch)
2021-02-09 11:02 PST, Michael Catanzaro 		mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-02-09 11:02:45 PST
Created attachment 419743 [details] Patch
Michael Catanzaro
Comment 2 2021-02-09 12:02:01 PST
Comment on attachment 419743 [details] Patch This will conflict with and is obsoleted by Devin's patch in bug #221621.
Note You need to log in before you can comment on or make changes to this bug.