Bug 221575

Summary: Use CompletionHandler instead of BoolCallback
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2021-02-08 14:35:34 PST
Use CompletionHandler instead of BoolCallback
Attachments
Patch (17.97 KB, patch)
2021-02-08 14:50 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-02-08 14:50:55 PST
Created attachment 419632 [details] Patch
Chris Dumez
Comment 2 2021-02-08 16:11:07 PST
Comment on attachment 419632 [details] Patch r=me
EWS
Comment 3 2021-02-08 16:22:30 PST
Committed r272558: <https://commits.webkit.org/r272558> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419632 [details].
Darin Adler
Comment 4 2021-02-08 16:35:11 PST
Are we close to being able to remove all the callbacks?
Darin Adler
Comment 5 2021-02-08 16:35:28 PST
Kind of idly wondering if whatever BoolCallback crash we had might affect the others too.
Alex Christensen
Comment 6 2021-02-08 18:57:37 PST
I'm on my way to removing all use of GenericCallback. It's one of those morning warm-up tasks. It'll probably take a few more weeks. The code that uses it is quite old and convoluted.
Radar WebKit Bug Importer
Comment 7 2021-02-10 14:32:35 PST
<rdar://problem/74206594>
Note You need to log in before you can comment on or make changes to this bug.