Bug 221575

Summary: Use CompletionHandler instead of BoolCallback
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Alex Christensen 2021-02-08 14:35:34 PST
Use CompletionHandler instead of BoolCallback
Comment 1 Alex Christensen 2021-02-08 14:50:55 PST
Created attachment 419632 [details]
Comment 2 Chris Dumez 2021-02-08 16:11:07 PST
Comment on attachment 419632 [details]

Comment 3 EWS 2021-02-08 16:22:30 PST
Committed r272558: <https://commits.webkit.org/r272558>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419632 [details].
Comment 4 Darin Adler 2021-02-08 16:35:11 PST
Are we close to being able to remove all the callbacks?
Comment 5 Darin Adler 2021-02-08 16:35:28 PST
Kind of idly wondering if whatever BoolCallback crash we had might affect the others too.
Comment 6 Alex Christensen 2021-02-08 18:57:37 PST
I'm on my way to removing all use of GenericCallback.  It's one of those morning warm-up tasks.  It'll probably take a few more weeks.  The code that uses it is quite old and convoluted.
Comment 7 Radar WebKit Bug Importer 2021-02-10 14:32:35 PST