Bug 221543

Summary: [SOUP] Simplify ResourceRequest and ResourceResponse
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220508    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2021-02-08 04:10:43 PST
There's unused code there and it can be refactored a bit
Attachments
Patch (28.98 KB, patch)
2021-02-08 04:33 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-02-08 04:33:33 PST
Created attachment 419573 [details] Patch
Adrian Perez
Comment 2 2021-02-08 07:13:10 PST
Comment on attachment 419573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419573&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:63 > + GRefPtr<SoupMessage> soupMessage = adoptGRef(soup_message_new_from_uri(httpMethod().ascii().data(), uri.get())); I would have used “auto” here because the “adoptGRef()” + “soup_message_new_foo()” calls already make it quite clear that the inferred type will be “GRefPtr<SoupMessage>” No strong preference, though. > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-174 > - Nice to see some code go away \o/
Carlos Garcia Campos
Comment 3 2021-02-10 01:41:26 PST
Committed r272641: <https://trac.webkit.org/changeset/272641>
Radar WebKit Bug Importer
Comment 4 2021-02-10 01:42:14 PST
<rdar://problem/74180921>
Note You need to log in before you can comment on or make changes to this bug.