Bug 221543

Summary:

[SOUP] Simplify ResourceRequest and ResourceResponse

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, berto, bugs-noreply, ews-watchlist, gustavo, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

220508

Attachments:

Description	Flags
Patch	aperez: review+

Description Carlos Garcia Campos 2021-02-08 04:10:43 PST

There's unused code there and it can be refactored a bit

Comment 1 Carlos Garcia Campos 2021-02-08 04:33:33 PST

Created attachment 419573 [details]
Patch

Comment 2 Adrian Perez 2021-02-08 07:13:10 PST

Comment on attachment 419573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419573&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:63
> +    GRefPtr<SoupMessage> soupMessage = adoptGRef(soup_message_new_from_uri(httpMethod().ascii().data(), uri.get()));

I would have used “auto” here because the “adoptGRef()” + “soup_message_new_foo()”
calls already make it quite clear that the inferred type will be “GRefPtr<SoupMessage>”
No strong preference, though.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-174
> -

Nice to see some code go away \o/

Comment 3 Carlos Garcia Campos 2021-02-10 01:41:26 PST

Committed r272641: <https://trac.webkit.org/changeset/272641>

Comment 4 Radar WebKit Bug Importer 2021-02-10 01:42:14 PST

<rdar://problem/74180921>