Summary: | [LayoutTests] Convert http/tests/css convert PHP to Python | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Gambrell <cgambrell> | ||||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220749 | ||||||||||||||
Attachments: |
|
Description
Chris Gambrell
2021-02-05 18:04:06 PST
Created attachment 419782 [details]
Patch
Comment on attachment 419782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419782&action=review > LayoutTests/http/tests/css/resources/500.py:9 > + 'HTTP/1.0 500 Internal Error\r\n' Shouldn't this just be: 'status: 500\r\n'? > LayoutTests/http/tests/css/resources/webfont-request.py:21 > +sys.path.insert(0, http_root) Does not look like we actually need this, since you aren't using any shared code > LayoutTests/http/tests/css/resources/webfont-request.py:37 > + 'Content-Type: application/octet-stream\r\n\r\n' "echo" results in a newline, so we should add a \n to this string > LayoutTests/http/tests/css/resources/webfont-request.py:44 > + '{}'.format(currentCount) "echo" results in a newline, so we should add a \n to this string Created attachment 419796 [details]
Patch
Created attachment 419798 [details]
Patch
Created attachment 419799 [details]
Patch
Created attachment 419800 [details]
Patch
(In reply to Jonathan Bedard from comment #3) > Comment on attachment 419782 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419782&action=review > > > LayoutTests/http/tests/css/resources/500.py:9 > > + 'HTTP/1.0 500 Internal Error\r\n' > > Shouldn't this just be: 'status: 500\r\n'? > Changed the header to match correct python style > > LayoutTests/http/tests/css/resources/webfont-request.py:21 > > +sys.path.insert(0, http_root) > > Does not look like we actually need this, since you aren't using any shared > code > Removed 3 unused lines > > LayoutTests/http/tests/css/resources/webfont-request.py:37 > > + 'Content-Type: application/octet-stream\r\n\r\n' > > "echo" results in a newline, so we should add a \n to this string > Found out that PHP's echo doesn't add a new line, must be the print func > > LayoutTests/http/tests/css/resources/webfont-request.py:44 > > + '{}'.format(currentCount) > > "echo" results in a newline, so we should add a \n to this string > Found out that PHP's echo doesn't add a new line, must be the print func Committed r272656: <https://commits.webkit.org/r272656> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419800 [details]. |