Bug 221507

Summary: Deploy WTFMove in the constructor for AutofillElements
Product: WebKit Reporter: Ricky Mondello <rmondello>
Component: FormsAssignee: Ricky Mondello <rmondello>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
wenson_hsieh: review+, wenson_hsieh: commit-queue-
Patch (with ChangeLog file! ha!)
none
third time’s the charm (correctly formatted ChangeLog?)
none
patch
none
Patch! none

Ricky Mondello
Reported 2021-02-05 15:50:23 PST
Deploy WTFMove in the constructor for AutofillElements
Attachments
Patch (1.20 KB, patch)
2021-02-05 15:50 PST, Ricky Mondello 		wenson_hsieh: review+
wenson_hsieh: commit-queue-
DetailsFormatted DiffDiff
Patch (with ChangeLog file! ha!) (1.82 KB, patch)
2021-02-05 15:55 PST, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
third time’s the charm (correctly formatted ChangeLog?) (1.93 KB, patch)
2021-02-05 15:59 PST, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
patch (1.93 KB, patch)
2021-02-05 16:06 PST, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
Patch! (1.93 KB, patch)
2021-02-05 16:08 PST, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ricky Mondello
Comment 1 2021-02-05 15:50:39 PST
Created attachment 419474 [details] Patch
Wenson Hsieh
Comment 2 2021-02-05 15:51:47 PST
Comment on attachment 419474 [details] Patch LGTM (but needs a ChangeLog!)
Ricky Mondello
Comment 3 2021-02-05 15:55:34 PST
Created attachment 419475 [details] Patch (with ChangeLog file! ha!)
Ricky Mondello
Comment 4 2021-02-05 15:59:09 PST
Created attachment 419476 [details] third time’s the charm (correctly formatted ChangeLog?)
Ricky Mondello
Comment 5 2021-02-05 16:06:08 PST
Created attachment 419478 [details] patch
Ricky Mondello
Comment 6 2021-02-05 16:08:51 PST
Created attachment 419480 [details] Patch!
EWS
Comment 7 2021-02-05 16:49:33 PST
Committed r272453: <https://trac.webkit.org/changeset/272453> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419480 [details].
Radar WebKit Bug Importer
Comment 8 2021-02-05 16:50:15 PST
<rdar://problem/74047502>
Note You need to log in before you can comment on or make changes to this bug.