Bug 221507 - Deploy WTFMove in the constructor for AutofillElements
Summary: Deploy WTFMove in the constructor for AutofillElements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ricky Mondello
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-05 15:50 PST by Ricky Mondello
Modified: 2021-02-05 16:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.20 KB, patch)
2021-02-05 15:50 PST, Ricky Mondello
wenson_hsieh: review+
wenson_hsieh: commit-queue-
Details | Formatted Diff | Diff
Patch (with ChangeLog file! ha!) (1.82 KB, patch)
2021-02-05 15:55 PST, Ricky Mondello
no flags Details | Formatted Diff | Diff
third time’s the charm (correctly formatted ChangeLog?) (1.93 KB, patch)
2021-02-05 15:59 PST, Ricky Mondello
no flags Details | Formatted Diff | Diff
patch (1.93 KB, patch)
2021-02-05 16:06 PST, Ricky Mondello
no flags Details | Formatted Diff | Diff
Patch! (1.93 KB, patch)
2021-02-05 16:08 PST, Ricky Mondello
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ricky Mondello 2021-02-05 15:50:23 PST
Deploy WTFMove in the constructor for AutofillElements
Comment 1 Ricky Mondello 2021-02-05 15:50:39 PST
Created attachment 419474 [details]
Patch
Comment 2 Wenson Hsieh 2021-02-05 15:51:47 PST
Comment on attachment 419474 [details]
Patch

LGTM (but needs a ChangeLog!)
Comment 3 Ricky Mondello 2021-02-05 15:55:34 PST
Created attachment 419475 [details]
Patch (with ChangeLog file! ha!)
Comment 4 Ricky Mondello 2021-02-05 15:59:09 PST
Created attachment 419476 [details]
third time’s the charm (correctly formatted ChangeLog?)
Comment 5 Ricky Mondello 2021-02-05 16:06:08 PST
Created attachment 419478 [details]
patch
Comment 6 Ricky Mondello 2021-02-05 16:08:51 PST
Created attachment 419480 [details]
Patch!
Comment 7 EWS 2021-02-05 16:49:33 PST
Committed r272453: <https://trac.webkit.org/changeset/272453>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419480 [details].
Comment 8 Radar WebKit Bug Importer 2021-02-05 16:50:15 PST
<rdar://problem/74047502>