Bug 221504

Summary: REGRESSION(r271575) [GStreamer] webrtc/peer-connection-remote-audio-mute2.html is failing
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WebRTCAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, crzwdjk, dpino, pnormand, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220599
Attachments:
Description Flags
Patch
none
Patch dpino: commit-queue+

Lauro Moura
Reported 2021-02-05 14:33:43 PST
webrtc/peer-connection-remote-audio-mute2.html r271575 changed MediaStreamTrack to create a new AudioSourceProvider for each node instead of keeping ownership of a single provider and sharing it. Maybe there is some path in gstreamer code that is still assuming the former behavior? Diff: --- /home/lauro/dev/WebKit/layout-test-results/webrtc/peer-connection-remote-audio-mute2-expected.txt +++ /home/lauro/dev/WebKit/layout-test-results/webrtc/peer-connection-remote-audio-mute2-actual.txt @@ -1,3 +1,3 @@ -PASS Muting and unmuting an incoming audio track +FAIL Muting and unmuting an incoming audio track assert_true: not heard hum from remote disabled track expected true got false
Attachments
Patch (1.45 KB, patch)
2021-06-24 10:13 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2021-06-24 11:00 PDT, Arcady Goldmints-Orlov 		dpino: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-02-16 09:31:42 PST
webrtc/peer-connection-remote-audio-mute.html This one is also a regression from the same revision, but flaky failing/timing out.
Arcady Goldmints-Orlov
Comment 2 2021-05-25 12:24:42 PDT
This seems to be fixed as of r277175, I can remove the failure from the TestExpectations.
Arcady Goldmints-Orlov
Comment 3 2021-06-24 10:13:19 PDT
Created attachment 432183 [details] Patch
EWS
Comment 4 2021-06-24 10:27:46 PDT
Downloading mechanize-0.4.5... Installing mechanize-0.4.5... Installed mechanize-0.4.5! /Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Arcady Goldmints-Orlov
Comment 5 2021-06-24 11:00:30 PDT
Created attachment 432192 [details] Patch
EWS
Comment 6 2021-06-24 11:27:50 PDT
Committed r279239 (239124@main): <https://commits.webkit.org/239124@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432192 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-24 11:28:25 PDT
<rdar://problem/79734156>
Note You need to log in before you can comment on or make changes to this bug.