Summary: | REGRESSION (r271815): [macOS] /dev/dtracehelper is blocked on customer builds, even with SIP disabled | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, bfulgham, pvollan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220927 | ||||||||||||
Attachments: |
|
Description
Brent Fulgham
2021-02-05 14:00:14 PST
Created attachment 419460 [details]
Patch
Comment on attachment 419460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419460&action=review Great! R=me. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:710 > + dispatch_once(&onceToken, ^{ > + isSIPDisabled = !csr_check(CSR_DISABLE_FLAGS); Since this only seems to be called on the main thread, I think the dispatch_once is not needed. (In reply to Brent Fulgham from comment #2) > Created attachment 419460 [details] > Patch On second thought, none of the SIP flags seem related to the GL profiler, so let's leave that for future consideration. Also, it turns out the Sandbox already has features to check CSR. Created attachment 419469 [details]
Patch
Comment on attachment 419469 [details]
Patch
R=me.
Created attachment 419471 [details]
Patch
Comment on attachment 419471 [details]
Patch
R=me.
Created attachment 419473 [details]
Patch for landing
I confirmed that the CSR filter has been present since 2015, so we are safe to adopt without conditionals. Committed r272449: <https://trac.webkit.org/changeset/272449> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419473 [details]. |