Bug 221501

Summary:

REGRESSION (r271815): [macOS] /dev/dtracehelper is blocked on customer builds, even with SIP disabled

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, pvollan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220927

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

Brent Fulgham

Reported 2021-02-05 14:00:14 PST

The change in Bug 220927 was not implemented correctly: we should have gated access to /dev/dtracehelper on whether SIP disabled, not on AppleInternal. We should likewise allow OpenGL Profiler to attach if SIP is disabled.

Attachments
Patch (3.59 KB, patch) 2021-02-05 14:06 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (1.69 KB, patch) 2021-02-05 14:49 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (1.74 KB, patch) 2021-02-05 14:56 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch for landing (1.70 KB, patch) 2021-02-05 15:36 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2021-02-05 14:00:36 PST

<rdar://73893768>

Brent Fulgham

Comment 2 2021-02-05 14:06:19 PST

Created attachment 419460 [details] Patch

Per Arne Vollan

Comment 3 2021-02-05 14:16:30 PST

Comment on attachment 419460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419460&action=review Great! R=me. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:710 > + dispatch_once(&onceToken, ^{ > + isSIPDisabled = !csr_check(CSR_DISABLE_FLAGS); Since this only seems to be called on the main thread, I think the dispatch_once is not needed.

Brent Fulgham

Comment 4 2021-02-05 14:49:01 PST

(In reply to Brent Fulgham from comment #2) > Created attachment 419460 [details] > Patch On second thought, none of the SIP flags seem related to the GL profiler, so let's leave that for future consideration. Also, it turns out the Sandbox already has features to check CSR.

Brent Fulgham

Comment 5 2021-02-05 14:49:49 PST

Created attachment 419469 [details] Patch

Per Arne Vollan

Comment 6 2021-02-05 14:53:58 PST

Comment on attachment 419469 [details] Patch R=me.

Brent Fulgham

Comment 7 2021-02-05 14:56:23 PST

Created attachment 419471 [details] Patch

Per Arne Vollan

Comment 8 2021-02-05 15:08:08 PST

Comment on attachment 419471 [details] Patch R=me.