| Summary: | [Interop 2021][css-flexbox] align/justify problems with static positions of abspos items | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED --- | ||
| Severity: | Normal | CC: | bfulgham, commit-queue, jensimmons, lmoura, rreno, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 245292 | ||
| Bug Blocks: | 136754 | ||
|
Description
Sergio Villar Senin
2021-02-05 09:17:25 PST
After 242101@main updated the tests, the only remaining failures are: imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-safe-001.html imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-fallback-align-content-001.html imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-002.html Gardened the new passes in 242176@main These test failures: https://wpt.fyi/results/css/css-flexbox/abspos?label=master&label=experimental&aligned&q=align-content The align-content failures are because we ignore it when computing the position of out of flow children and only respect align-self. It's just a coincidence that we are passing any of these subtests - the expected location of the boxes happens to be where we place them because of align-self: center being used to calculate position. Here is the offending code: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFlexibleBox.cpp#1737 We are computing alignmentOffset for the child's alignment which is resolving align-self. Pull request: https://github.com/WebKit/WebKit/pull/3170 Committed 253389@main (62e012dfc64a): <https://commits.webkit.org/253389@main> Reviewed commits have been landed. Closing PR #3170 and removing active labels. Re-opened since this is blocked by bug 245292 |