Bug 221468

Summary:

[css-flexbox] align-content issues

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

Layout and Rendering

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, clopez, dino, ews-watchlist, graouts, koivisto, rniwa, simon.fraser, webkit-bug-importer, youennf, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

136754

Attachments:

Description	Flags
Patch	none

Description Sergio Villar Senin 2021-02-05 09:00:47 PST

This newly imported WPT tests have failing subtests:

LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-horiz-001a.html
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-horiz-001b.html
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-horiz-002.html
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-vert-001a.html
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-vert-001b.html
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-vert-002.html
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-wmvert-001.html

Comment 1 Sergio Villar Senin 2021-02-05 09:02:28 PST

Also these test failures:

imported/w3c/web-platform-tests/css/css-flexbox/align-content_center.html
imported/w3c/web-platform-tests/css/css-flexbox/align-content_flex-end.html
imported/w3c/web-platform-tests/css/css-flexbox/align-content_flex-start.html
imported/w3c/web-platform-tests/css/css-flexbox/align-content_space-around.html
imported/w3c/web-platform-tests/css/css-flexbox/align-content_space-between.html
imported/w3c/web-platform-tests/css/css-flexbox/align-content_stretch.html

Comment 2 Radar WebKit Bug Importer 2021-02-12 09:01:13 PST

<rdar://problem/74278321>

Comment 3 Sergio Villar Senin 2021-03-31 11:26:36 PDT

Created attachment 424789 [details]
Patch

Comment 4 EWS Watchlist 2021-03-31 11:27:33 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Comment 5 EWS 2021-04-02 03:59:44 PDT

Committed r275416: <https://commits.webkit.org/r275416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424789 [details].