Bug 221433

Summary: REGRESSION (r272382): 2 webkit.messages_unittest.GeneratedFileContentsTest tests failing after Semaphore.h rename
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ross.kirsling, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221418
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2021-02-04 15:53:35 PST
[5/1961] webkit.messages_unittest.GeneratedFileContentsTest.test_message_argument_description failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 100, in test_message_argument_description self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, 'MessageArgumentDescriptions.cpp')) File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 77, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: '#include "IPCSemaphore.h"' != '#include "JSIPCBinding.h"' [12/1961] webkit.messages_unittest.GeneratedFileContentsTest.test_receiver failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 89, in test_receiver self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, '{}MessageReceiver.cpp'.format(receiver_name))) File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 77, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: '#include "IPCSemaphore.h"' != '#include "Semaphore.h"'
Attachments
Patch (2.10 KB, patch)
2021-02-04 16:20 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-02-04 16:05:54 PST
Great, it's not just arcane but also fragile... 🙄
Ross Kirsling
Comment 2 2021-02-04 16:17:25 PST
Er wait, no, it looks like the changes to those two files just got dropped from the patch in the process of trying to figure out how the generator script works.
Ross Kirsling
Comment 3 2021-02-04 16:20:16 PST
Created attachment 419335 [details] Patch
EWS
Comment 4 2021-02-04 17:11:31 PST
Committed r272400: <https://trac.webkit.org/changeset/272400> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419335 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-04 17:12:14 PST
<rdar://problem/74004365>
Note You need to log in before you can comment on or make changes to this bug.