Bug 221421

Summary: ConsoleMessage: Don't encode string JSONLogValue's as JSON
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: JavaScriptCoreAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, eric.carlson, ews-watchlist, gyuyoung.kim, hi, joepeck, keith_miller, mark.lam, msaboff, pnormand, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221539
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description Alicia Boya García 2021-02-04 11:41:10 PST 
JSONLogValue's have two tagged types: String and JSON. Despite this,
the ConsoleMessage constructor was converting the string values to
JSON while coalescing them.

This also added quotes on the return value of message() for
ConsoleMessage's created with this constructor, but not with others.

This patch removes that behavior, keeping strings as strings and using
wrapObject() instead of wrapJSONString() for them.
Comment 1 Alicia Boya García 2021-02-04 11:46:34 PST 
Created attachment 419306 [details]
Patch
Comment 2 Philippe Normand 2021-02-05 07:21:07 PST 
Created attachment 419400 [details]
Patch
Comment 3 Philippe Normand 2021-02-05 07:21:54 PST 
This is Alicia's patch, I'm only driving-by hoping to fix the wincairo EWS...
Comment 4 Philippe Normand 2021-02-05 07:42:38 PST 
Created attachment 419406 [details]
Patch
Comment 5 Philippe Normand 2021-02-05 08:32:49 PST 
Created attachment 419412 [details]
Patch
Comment 6 Philippe Normand 2021-02-05 09:18:16 PST 
Created attachment 419416 [details]
Patch
Comment 7 Alicia Boya García 2021-02-05 13:10:00 PST 
Created attachment 419451 [details]
Patch
Comment 8 Alicia Boya García 2021-02-05 13:10:43 PST 
Added missing ChangeLog entries.
Comment 9 EWS 2021-02-08 01:47:32 PST 
Committed r272484: <https://commits.webkit.org/r272484>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419451 [details].
Comment 10 Radar WebKit Bug Importer 2021-02-10 14:41:52 PST 
<rdar://problem/74207049>