Bug 221421

Summary:

ConsoleMessage: Don't encode string JSONLogValue's as JSON

Product:

WebKit

Reporter:

Alicia Boya García <aboya>

Component:

JavaScriptCore

Assignee:

Alicia Boya García <aboya>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, eric.carlson, ews-watchlist, gyuyoung.kim, hi, joepeck, keith_miller, mark.lam, msaboff, pnormand, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=221539

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none

Alicia Boya García

Reported 2021-02-04 11:41:10 PST

JSONLogValue's have two tagged types: String and JSON. Despite this, the ConsoleMessage constructor was converting the string values to JSON while coalescing them. This also added quotes on the return value of message() for ConsoleMessage's created with this constructor, but not with others. This patch removes that behavior, keeping strings as strings and using wrapObject() instead of wrapJSONString() for them.

Attachments
Patch (8.01 KB, patch) 2021-02-04 11:46 PST, Alicia Boya García	no flags	Details Formatted Diff Diff
Patch (8.33 KB, patch) 2021-02-05 07:21 PST, Philippe Normand	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.64 KB, patch) 2021-02-05 07:42 PST, Philippe Normand	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.46 KB, patch) 2021-02-05 08:32 PST, Philippe Normand	no flags	Details Formatted Diff Diff
Patch (10.69 KB, patch) 2021-02-05 09:18 PST, Philippe Normand	no flags	Details Formatted Diff Diff
Patch (11.48 KB, patch) 2021-02-05 13:10 PST, Alicia Boya García	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.