Bug 221406 – Some privateClickMeasurement might output the information in different order depending on platform

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be different for different platforms. We could just check every value we want to show to make sure we always provide them in the same order.

[Carlos Garcia Campos]

Created attachment 419283 [details]
Patch

[Kate Cheney]

Comment on attachment 419283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419283&action=review

> LayoutTests/ChangeLog:8
> +        The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be

nit: header's order

> LayoutTests/http/tests/privateClickMeasurement/resources/conversionReport.php:8
> +if (array_key_exists("HTTP_HOST", $httpHeaders)) {

Could you do something like “if ($value = $httpHeaders[“HTTP_HOST”]) or will that not work in php? It would turn 2 lines into 1, and only require one lookup. Ditto for all the rest.

[Carlos Garcia Campos]

Comment on attachment 419283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419283&action=review

>> LayoutTests/ChangeLog:8
>> +        The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be
> 
> nit: header's order

Ok.

>> LayoutTests/http/tests/privateClickMeasurement/resources/conversionReport.php:8
>> +if (array_key_exists("HTTP_HOST", $httpHeaders)) {
> 
> Could you do something like “if ($value = $httpHeaders[“HTTP_HOST”]) or will that not work in php? It would turn 2 lines into 1, and only require one lookup. Ditto for all the rest.

I don't know php, so I'll just try that

[Carlos Garcia Campos]

Created attachment 419393 [details]
Patch

[Carlos Garcia Campos]

Committed r272642: <https://trac.webkit.org/changeset/272642>

[Radar WebKit Bug Importer]

<rdar://problem/74180943>