Bug 221401

Summary: Remove GPUProcess flag in MediaRecorder tests
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207166
https://bugs.webkit.org/show_bug.cgi?id=221505
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description youenn fablet 2021-02-04 04:34:41 PST
Remove GPUProcess flag in MediaRecorder tests
Comment 1 youenn fablet 2021-02-04 04:44:42 PST
Created attachment 419273 [details]
Patch
Comment 2 youenn fablet 2021-02-04 06:46:28 PST
Created attachment 419279 [details]
Patch
Comment 3 youenn fablet 2021-02-05 05:48:30 PST
ping review
Comment 4 EWS 2021-02-05 10:49:54 PST
Committed r272426: <https://trac.webkit.org/changeset/272426>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419279 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-05 10:50:15 PST
<rdar://problem/74031611>
Comment 6 Ryan Haddad 2021-02-09 14:10:53 PST
This change caused http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html to consistently fail on macOS (See http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html), and appears to have made it flaky on iOS.
Comment 7 Ryan Haddad 2021-02-09 14:13:05 PST
Reverted r272426 for reason:

Caused test failures / flakiness

Committed r272613: <https://trac.webkit.org/changeset/272613>
Comment 8 youenn fablet 2021-02-11 06:12:00 PST
Created attachment 419981 [details]
Patch
Comment 9 youenn fablet 2021-02-11 06:13:22 PST
(In reply to Ryan Haddad from comment #7)
> Reverted r272426 for reason:
> 
> Caused test failures / flakiness
> 
> Committed r272613: <https://trac.webkit.org/changeset/272613>

Relanding part of the change related to http/wpt/mediarecorder/pause-recording.html.
I will wait for the other part of the changes until rdar://problem/74043225 is fixed.
Comment 10 EWS 2021-02-11 06:40:43 PST
Committed r272722: <https://commits.webkit.org/r272722>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419981 [details].