Summary: | Link libnetworkextension at compile time | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, dino, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kate Cheney
2021-02-03 18:20:15 PST
Created attachment 419282 [details]
Patch
Comment on attachment 419282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419282&action=review This is almost correct, but I think it will break Base System in its current form. > Source/WebKit/Configurations/WebKit.xcconfig:137 > +WK_LIBNETWORKEXTENSION_LDFLAGS_macosx = -lnetworkextension; In Bug 218314 (r269173) we used "WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension;" because this library is not present in the Base System (recovery mode). I think we need to do the same here. Created attachment 419296 [details]
Patch
Comment on attachment 419296 [details]
Patch
r=me
Committed r272387: <https://trac.webkit.org/changeset/272387> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419296 [details]. |