Bug 221362

Summary: Allow highlight delegate to be set on WKWebView
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2021-02-03 15:52:55 PST
Allow highlight delegate to be set on WKWebView
Attachments
Patch (1.87 KB, patch)
2021-02-03 15:53 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2021-02-03 16:05 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.81 KB, patch)
2021-02-03 16:26 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.80 KB, patch)
2021-02-04 12:13 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.80 KB, patch)
2021-02-04 13:51 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-02-03 15:53:43 PST
Created attachment 419199 [details] Patch
Wenson Hsieh
Comment 2 2021-02-03 16:00:35 PST
Comment on attachment 419199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419199&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:139 > +@protocol _WKAppHighlightDelegate; Nit - keep these sorted alphabetically?
Megan Gardner
Comment 3 2021-02-03 16:05:47 PST
Created attachment 419200 [details] Patch
Megan Gardner
Comment 4 2021-02-03 16:26:44 PST
Created attachment 419204 [details] Patch
Tim Horton
Comment 5 2021-02-03 18:11:16 PST
Comment on attachment 419204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419204&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1417 > +#endif #else! two returns in a row is bizarre > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:368 > +@property (nonatomic, weak, setter=_setAppHighlightsDelegate:) id <_WKAppHighlightDelegate> _appHighlightsDelegate WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); is it highlight or highlights? Please decide, now you've got both in one line (and this seems like the opportunity to fix the property name).
Megan Gardner
Comment 6 2021-02-04 12:13:32 PST
Created attachment 419310 [details] Patch
Megan Gardner
Comment 7 2021-02-04 13:51:50 PST
Created attachment 419317 [details] Patch for landing
EWS
Comment 8 2021-02-04 14:20:54 PST
Committed r272386: <https://trac.webkit.org/changeset/272386> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419317 [details].
Radar WebKit Bug Importer
Comment 9 2021-02-04 14:21:13 PST
<rdar://problem/73997198>
Note You need to log in before you can comment on or make changes to this bug.