| Summary: | Allow highlight delegate to be set on WKWebView | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | hi, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Megan Gardner
2021-02-03 15:52:55 PST
Created attachment 419199 [details]
Patch
Comment on attachment 419199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419199&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:139 > +@protocol _WKAppHighlightDelegate; Nit - keep these sorted alphabetically? Created attachment 419200 [details]
Patch
Created attachment 419204 [details]
Patch
Comment on attachment 419204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419204&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1417 > +#endif #else! two returns in a row is bizarre > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:368 > +@property (nonatomic, weak, setter=_setAppHighlightsDelegate:) id <_WKAppHighlightDelegate> _appHighlightsDelegate WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); is it highlight or highlights? Please decide, now you've got both in one line (and this seems like the opportunity to fix the property name). Created attachment 419310 [details]
Patch
Created attachment 419317 [details]
Patch for landing
Committed r272386: <https://trac.webkit.org/changeset/272386> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419317 [details]. |