Bug 22136

Summary: [Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 19428    
Attachments:
Description Flags
Refactor and move shareable code in autotools/webkit.m4 zimmermann: review+

Jan Alonzo
Reported 2008-11-07 20:46:50 PST
Some checks (glib and unicode dependencies) and constructs are actually shareable between JSC and WebKit builds so we need to somehow reuse the same code once we split the JSC and WebKit builds.
Attachments
Refactor and move shareable code in autotools/webkit.m4 (38.01 KB, patch)
2008-11-07 20:52 PST, Jan Alonzo 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2008-11-07 20:52:34 PST
Created attachment 24984 [details] Refactor and move shareable code in autotools/webkit.m4 1. Create an autotools dir for some autotools-related scripts 2. Move acinclude.m4 amd symbols.filter in autotools/ 3. Extract dolt stuff out of acinclude.m4 and put it in autotools/dolt.m4 4. Move shareable code out of configure.ac and into autotools/webkit.m4
Nikolas Zimmermann
Comment 2 2009-01-22 20:31:59 PST
Comment on attachment 24984 [details] Refactor and move shareable code in autotools/webkit.m4 Looks good to me. In case no builds are broken, r=me.
Jan Alonzo
Comment 3 2009-01-31 01:59:53 PST
Thanks Niko. Landed in r40450.
Note You need to log in before you can comment on or make changes to this bug.