Bug 221353

Summary: [JSC] Insert PhantomLocal just before SetLocal for |this| to ensure liveness
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hexiaoyu, keith_miller, mark.lam, msaboff, saam, tzagallo, virustacker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Yusuke Suzuki 2021-02-03 12:48:58 PST 
[JSC] Update Graph::needsFlushedThis
Comment 1 Yusuke Suzuki 2021-02-03 13:02:06 PST 
Created attachment 419177 [details]
Patch
Comment 2 Yusuke Suzuki 2021-02-03 13:03:44 PST 
<rdar://problem/70373862>
Comment 3 Yusuke Suzuki 2021-02-03 13:30:00 PST 
Discussed with Saam. We should insert PhantomLocal instead to make liveness correct.
Comment 4 Yusuke Suzuki 2021-02-03 13:30:35 PST 
Created attachment 419181 [details]
Patch
Comment 5 Yusuke Suzuki 2021-02-03 13:31:11 PST 
Comment on attachment 419181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419181&action=review

> Source/JavaScriptCore/dfg/DFGVariableAccessDataDump.cpp:58
> +    } while (index);

This is just for fixing formatting of VariableAccessData. Previously, if index = 0 (|this|), it does not dump unbox info etc.
Comment 6 Yusuke Suzuki 2021-02-03 13:32:02 PST 
Created attachment 419184 [details]
Patch
Comment 7 Saam Barati 2021-02-03 15:22:15 PST 
Comment on attachment 419184 [details]
Patch

Nice. r=me
Comment 8 EWS 2021-02-03 16:10:14 PST 
Committed r272349: <https://trac.webkit.org/changeset/272349>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419184 [details].
Comment 9 Michael Saboff 2021-02-23 15:37:17 PST 
*** Bug 222152 has been marked as a duplicate of this bug. ***
Comment 10 Yusuke Suzuki 2021-04-10 01:13:19 PDT 
*** Bug 224354 has been marked as a duplicate of this bug. ***