Bug 221353

Summary: [JSC] Insert PhantomLocal just before SetLocal for |this| to ensure liveness
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hexiaoyu, keith_miller, mark.lam, msaboff, saam, tzagallo, virustacker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2021-02-03 12:48:58 PST
[JSC] Update Graph::needsFlushedThis
Attachments
Patch (13.79 KB, patch)
2021-02-03 13:02 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.38 KB, patch)
2021-02-03 13:30 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.50 KB, patch)
2021-02-03 13:32 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-02-03 13:02:06 PST
Created attachment 419177 [details] Patch
Yusuke Suzuki
Comment 2 2021-02-03 13:03:44 PST
<rdar://problem/70373862>
Yusuke Suzuki
Comment 3 2021-02-03 13:30:00 PST
Discussed with Saam. We should insert PhantomLocal instead to make liveness correct.
Yusuke Suzuki
Comment 4 2021-02-03 13:30:35 PST
Created attachment 419181 [details] Patch
Yusuke Suzuki
Comment 5 2021-02-03 13:31:11 PST
Comment on attachment 419181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419181&action=review > Source/JavaScriptCore/dfg/DFGVariableAccessDataDump.cpp:58 > + } while (index); This is just for fixing formatting of VariableAccessData. Previously, if index = 0 (|this|), it does not dump unbox info etc.
Yusuke Suzuki
Comment 6 2021-02-03 13:32:02 PST
Created attachment 419184 [details] Patch
Saam Barati
Comment 7 2021-02-03 15:22:15 PST
Comment on attachment 419184 [details] Patch Nice. r=me
EWS
Comment 8 2021-02-03 16:10:14 PST
Committed r272349: <https://trac.webkit.org/changeset/272349> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419184 [details].
Michael Saboff
Comment 9 2021-02-23 15:37:17 PST
*** Bug 222152 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 10 2021-04-10 01:13:19 PDT
*** Bug 224354 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.