Summary: | WebXRSystem::RequestSession with 'viewer' as a required feature should succeed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Imanol Fernandez <ifernandez> | ||||||
Component: | WebXR | Assignee: | Imanol Fernandez <ifernandez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | svillar, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 208988 | ||||||||
Attachments: |
|
Description
Imanol Fernandez
2021-02-02 09:27:57 PST
Created attachment 419017 [details]
Patch
Comment on attachment 419017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419017&action=review > Source/WebCore/Modules/webxr/WebXRSystem.cpp:211 > + auto feature = parseEnumeration<XRReferenceSpaceType>(*globalObject.document()->globalObject(), features.first()); I guess you can directly use the document parameter instead of retrieving it from the DOMWindow. > LayoutTests/ChangeLog:8 > + * platform/wpe/TestExpectations: Nit: just add something like "marked a test as passing" or something like that. Created attachment 419591 [details]
Patch for landing
Committed r272492: <https://commits.webkit.org/r272492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419591 [details]. |