Bug 221238

Summary: Completion value of a finally block should not be ignored if completion is abrupt
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Ross Kirsling
Reported 2021-02-01 18:12:02 PST
Completion value of a finally block should not be ignored if completion is nabrupt
Attachments
Patch (6.45 KB, patch)
2021-02-01 18:23 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (11.04 KB, patch)
2021-02-01 19:12 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (11.09 KB, patch)
2021-02-01 19:20 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.83 KB, patch)
2021-02-02 12:22 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-02-01 18:23:31 PST
Created attachment 418950 [details] Patch
Ross Kirsling
Comment 2 2021-02-01 19:12:17 PST
Created attachment 418952 [details] Patch
Ross Kirsling
Comment 3 2021-02-01 19:20:46 PST
Created attachment 418953 [details] Patch
Yusuke Suzuki
Comment 4 2021-02-02 12:16:32 PST
Comment on attachment 418953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418953&action=review r=me > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4560 > + int finallyStartOffset = m_catchBlock ? m_catchBlock->endOffset() + 1 : m_tryBlock->endOffset() + 1; Let's put this before this if-else.
Ross Kirsling
Comment 5 2021-02-02 12:22:19 PST
Created attachment 419047 [details] Patch for landing
EWS
Comment 6 2021-02-02 15:24:53 PST
Committed r272243: <https://trac.webkit.org/changeset/272243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419047 [details].
Radar WebKit Bug Importer
Comment 7 2021-02-02 15:25:14 PST
<rdar://problem/73901838>
Note You need to log in before you can comment on or make changes to this bug.