Bug 221195

Summary: http/wpt/mediarecorder/mute-tracks.html is flaky
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, ryanhaddad, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220967    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2021-02-01 01:04:37 PST
http/wpt/mediarecorder/mute-tracks.html is flaky
Attachments
Patch (4.63 KB, patch)
2021-02-01 01:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2021-02-01 01:49 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.61 KB, patch)
2021-02-01 01:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.75 KB, patch)
2021-02-02 08:49 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.63 KB, patch)
2021-02-02 11:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-02-01 01:07:12 PST
Created attachment 418841 [details] Patch
youenn fablet
Comment 2 2021-02-01 01:49:08 PST
Created attachment 418845 [details] Patch
youenn fablet
Comment 3 2021-02-01 01:52:45 PST
Created attachment 418846 [details] Patch
youenn fablet
Comment 4 2021-02-01 05:25:08 PST
*** Bug 221161 has been marked as a duplicate of this bug. ***
youenn fablet
Comment 5 2021-02-01 05:25:33 PST
<rdar://problem/73775908>
Eric Carlson
Comment 6 2021-02-02 08:33:51 PST
Comment on attachment 418846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418846&action=review > LayoutTests/http/wpt/mediarecorder/mute-tracks.html:91 > - var context = new AudioContext(); > + let context = new AudioContext(); > + let analyser = setupAudioContext(context, streamOrVideo); > for (var cptr = 0; cptr < 20; cptr++) { > - var results = await analyseAudio(streamOrVideo, 200, context); > - if (results.heardHum === expected) > + var results = await analyseAudio(analyser, 200, context); Nit: it is inconsistent to change only some of the `var` declarations to `let`.
youenn fablet
Comment 7 2021-02-02 08:49:38 PST
Created attachment 419004 [details] Patch for landing
EWS
Comment 8 2021-02-02 11:09:18 PST
Found 1 new test failure: http/wpt/mediarecorder/mute-tracks.html
youenn fablet
Comment 9 2021-02-02 11:40:56 PST
Created attachment 419037 [details] Patch for landing
EWS
Comment 10 2021-02-02 15:41:42 PST
commit-queue failed to commit attachment 419037 [details] to WebKit repository.
EWS
Comment 11 2021-02-02 21:10:49 PST
Committed r272296: <https://trac.webkit.org/changeset/272296> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419037 [details].
Note You need to log in before you can comment on or make changes to this bug.