Bug 221186 – Detect unrecognized options in run-javascriptcore-tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Angelos Oikonomopoulos]

Detect unrecognized options in run-javascriptcore-tests

[Angelos Oikonomopoulos]

Created attachment 418825 [details]
Patch

[Keith Miller]

Comment on attachment 418825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418825&action=review

> Tools/ChangeLog:12
> +        through to build-jsc even when --no-build is used. However, when
> +        we're not building nothing will ever use or look at the extra
> +        arguments, which means that those arguments are silently eaten
> +        up. This means that typos in option names can go undetected.

Seems like a run-on sentence. Maybe it would be clearer as: 

However, when we're not building, nothing will ever use or look at the extra arguments. This means that those arguments are silently eaten up.

> Tools/Scripts/run-javascriptcore-tests:490
> +    # Assume any arguments left over from GetOptions are assumed to be build arguments

Seems like there's an existing typo. Can you change this to:

Assume any arguments left over from GetOptions are to be passed as build arguments.

[Angelos Oikonomopoulos]

Created attachment 418973 [details]
Patch

[Angelos Oikonomopoulos]

Thanks -- the new patch includes the wording fixes.

[Radar WebKit Bug Importer]

<rdar://problem/74072601>

[Angelos Oikonomopoulos]

Ping.

[Keith Miller]

r=me

[EWS]

Committed r273307: <https://commits.webkit.org/r273307>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418973 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 222320

[Keith Miller]

I think https://bugs.webkit.org/show_bug.cgi?id=222325 should fix the issue with the Cloop bot but I don't know how to test it locally.

[Angelos Oikonomopoulos]

(In reply to Keith Miller from comment #10)
> I think https://bugs.webkit.org/show_bug.cgi?id=222325 should fix the issue
> with the Cloop bot but I don't know how to test it locally.

Now that 222325 is in, perhaps we can try landing this patch again?

[Keith Miller]

(In reply to Angelos Oikonomopoulos from comment #11)
> (In reply to Keith Miller from comment #10)
> > I think https://bugs.webkit.org/show_bug.cgi?id=222325 should fix the issue
> > with the Cloop bot but I don't know how to test it locally.
> 
> Now that 222325 is in, perhaps we can try landing this patch again?

Not sure if cq+ing again works. You might need to upload a new copy of the patch. :/

[EWS]

ChangeLog entry in Tools/ChangeLog contains OOPS!.

[EWS]

commit-queue failed to commit attachment 418973 [details] to WebKit repository. To retry, please set cq+ flag again.

[Angelos Oikonomopoulos]

Created attachment 421948 [details]
Patch

[Angelos Oikonomopoulos]

(In reply to Keith Miller from comment #12)
[...]
> Not sure if cq+ing again works. You might need to upload a new copy of the
> patch. :/

Done!

[EWS]

commit-queue failed to commit attachment 421948 [details] to WebKit repository. To retry, please set cq+ flag again.

[Angelos Oikonomopoulos]

(In reply to EWS from comment #17)
> commit-queue failed to commit attachment 421948 [details] to WebKit
> repository. To retry, please set cq+ flag again.

I'm confused. push-commit-to-webkit-repo fails with

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: bd89e2521103c3f47dab717e6498ff947b9f9b29 and refs/remotes/origin/main differ, using rebase:
:040000 040000 ab97c4dac00c0354e4cd576430397ca9d44cc3ed 91dc1b3ad7a9b794b9f5036399ea0139abec72c1 M	Tools

But the patch doesn't touch WebKit/ChangeLog.

[EWS]

Committed r273883: <https://commits.webkit.org/r273883>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421948 [details].