Summary: | Detect unrecognized options in run-javascriptcore-tests | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, clopez, commit-queue, keith_miller, mark.lam, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 222320, 222321, 222325 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Angelos Oikonomopoulos
2021-01-31 06:49:46 PST
Created attachment 418825 [details]
Patch
Comment on attachment 418825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418825&action=review > Tools/ChangeLog:12 > + through to build-jsc even when --no-build is used. However, when > + we're not building nothing will ever use or look at the extra > + arguments, which means that those arguments are silently eaten > + up. This means that typos in option names can go undetected. Seems like a run-on sentence. Maybe it would be clearer as: However, when we're not building, nothing will ever use or look at the extra arguments. This means that those arguments are silently eaten up. > Tools/Scripts/run-javascriptcore-tests:490 > + # Assume any arguments left over from GetOptions are assumed to be build arguments Seems like there's an existing typo. Can you change this to: Assume any arguments left over from GetOptions are to be passed as build arguments. Created attachment 418973 [details]
Patch
Thanks -- the new patch includes the wording fixes. Ping. r=me Committed r273307: <https://commits.webkit.org/r273307> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418973 [details]. Re-opened since this is blocked by bug 222320 I think https://bugs.webkit.org/show_bug.cgi?id=222325 should fix the issue with the Cloop bot but I don't know how to test it locally. (In reply to Keith Miller from comment #10) > I think https://bugs.webkit.org/show_bug.cgi?id=222325 should fix the issue > with the Cloop bot but I don't know how to test it locally. Now that 222325 is in, perhaps we can try landing this patch again? (In reply to Angelos Oikonomopoulos from comment #11) > (In reply to Keith Miller from comment #10) > > I think https://bugs.webkit.org/show_bug.cgi?id=222325 should fix the issue > > with the Cloop bot but I don't know how to test it locally. > > Now that 222325 is in, perhaps we can try landing this patch again? Not sure if cq+ing again works. You might need to upload a new copy of the patch. :/ ChangeLog entry in Tools/ChangeLog contains OOPS!. commit-queue failed to commit attachment 418973 [details] to WebKit repository. To retry, please set cq+ flag again.
Created attachment 421948 [details]
Patch
(In reply to Keith Miller from comment #12) [...] > Not sure if cq+ing again works. You might need to upload a new copy of the > patch. :/ Done! commit-queue failed to commit attachment 421948 [details] to WebKit repository. To retry, please set cq+ flag again.
(In reply to EWS from comment #17) > commit-queue failed to commit attachment 421948 [details] to WebKit > repository. To retry, please set cq+ flag again. I'm confused. push-commit-to-webkit-repo fails with ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: bd89e2521103c3f47dab717e6498ff947b9f9b29 and refs/remotes/origin/main differ, using rebase: :040000 040000 ab97c4dac00c0354e4cd576430397ca9d44cc3ed 91dc1b3ad7a9b794b9f5036399ea0139abec72c1 M Tools But the patch doesn't touch WebKit/ChangeLog. Committed r273883: <https://commits.webkit.org/r273883> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421948 [details]. |