Bug 221162

Summary: autoinstall.py: Don't use an XML parser to parse HTML, fixes "mismatched tag" error
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: Tools / TestsAssignee: Alicia Boya García <aboya>
Severity: Normal CC: jbedard, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221111
Description Flags
Patch none

Description Alicia Boya García 2021-01-29 16:06:57 PST
Today autoinstall.py started failing becagse the page returned by
https://pypi.org/simple/fasteners/ now contains a <meta> tag, which is
not parseable as XML without the trailing slash.

This patch replaces that code to use an HTML parser instead of an XML
Comment 1 Alicia Boya García 2021-01-29 16:08:20 PST
Created attachment 418781 [details]
Comment 2 Alicia Boya García 2021-01-29 16:21:02 PST
Created attachment 418784 [details]
Comment 3 Jonathan Bedard 2021-01-29 16:44:41 PST
Alicia is right about this fix, although I'm reluctant to land something like this Friday afternoon given how much infrastructure we have relying on it. Since things are stable right now, I'll take a close look Monday morning.
Comment 4 EWS 2021-02-01 11:51:25 PST
commit-queue failed to commit attachment 418784 [details] to WebKit repository.
Comment 5 Jonathan Bedard 2021-02-01 11:55:34 PST
(In reply to EWS from comment #4)
> commit-queue failed to commit attachment 418784 [details] to WebKit
> repository.

Aakash and I are in discussion about this commit-queue issue now.
Comment 6 EWS 2021-02-01 12:37:50 PST
Committed r272167: <https://trac.webkit.org/changeset/272167>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418784 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-01 12:38:14 PST
Comment 8 Jonathan Bedard 2021-02-03 15:34:16 PST
*** Bug 221361 has been marked as a duplicate of this bug. ***