Bug 221162

Summary: autoinstall.py: Don't use an XML parser to parse HTML, fixes "mismatched tag" error
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: Tools / TestsAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221111
https://bugs.webkit.org/show_bug.cgi?id=221361
Attachments:
Description Flags
Patch
none
Patch none

Alicia Boya García
Reported 2021-01-29 16:06:57 PST
Today autoinstall.py started failing becagse the page returned by https://pypi.org/simple/fasteners/ now contains a <meta> tag, which is not parseable as XML without the trailing slash. This patch replaces that code to use an HTML parser instead of an XML parser.
Attachments
Patch (5.62 KB, patch)
2021-01-29 16:08 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (5.95 KB, patch)
2021-01-29 16:21 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2021-01-29 16:08:20 PST
Created attachment 418781 [details] Patch
Alicia Boya García
Comment 2 2021-01-29 16:21:02 PST
Created attachment 418784 [details] Patch
Jonathan Bedard
Comment 3 2021-01-29 16:44:41 PST
Alicia is right about this fix, although I'm reluctant to land something like this Friday afternoon given how much infrastructure we have relying on it. Since things are stable right now, I'll take a close look Monday morning.
EWS
Comment 4 2021-02-01 11:51:25 PST
commit-queue failed to commit attachment 418784 [details] to WebKit repository.
Jonathan Bedard
Comment 5 2021-02-01 11:55:34 PST
(In reply to EWS from comment #4) > commit-queue failed to commit attachment 418784 [details] to WebKit > repository. Aakash and I are in discussion about this commit-queue issue now.
EWS
Comment 6 2021-02-01 12:37:50 PST
Committed r272167: <https://trac.webkit.org/changeset/272167> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418784 [details].
Radar WebKit Bug Importer
Comment 7 2021-02-01 12:38:14 PST
<rdar://problem/73841294>
Jonathan Bedard
Comment 8 2021-02-03 15:34:16 PST
*** Bug 221361 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.