Bug 221150

Summary: [webkitcorepy] Support machines without Unix signal handling
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, don.olmstead, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-01-29 13:34:18 PST
Not all machines support signal.alarm. Our timeout code makes an effort to function without signal.alarm when possible. Timeout is much less robust without signal.alarm, but is still useful in many circumstances.
Attachments
Patch (6.51 KB, patch)
2021-01-29 13:41 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.10 KB, patch)
2021-01-29 17:00 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.13 KB, patch)
2021-02-01 10:42 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-29 13:34:30 PST
<rdar://problem/73769605>
Jonathan Bedard
Comment 2 2021-01-29 13:41:04 PST
Created attachment 418766 [details] Patch
Don Olmstead
Comment 3 2021-01-29 15:19:59 PST
Works for me locally with Python 3 on Windows! There are other cases where signal.SIGKILL is used which isn't present in Python for Windows so some more cross platform fixes should probably happen around usage of signal.
Jonathan Bedard
Comment 4 2021-01-29 16:48:28 PST
Looks like there are a few in task_pool.py and our mock popen code. We might also need to address this in webkitpy/common/interrupt_debugging.py, but that would have broken layout tests in Python 2 on Windows machines as well.
Jonathan Bedard
Comment 5 2021-01-29 17:00:15 PST
Created attachment 418788 [details] Patch
Aakash Jain
Comment 6 2021-02-01 10:01:04 PST
rs=me
Jonathan Bedard
Comment 7 2021-02-01 10:42:08 PST
Created attachment 418896 [details] Patch for landing
EWS
Comment 8 2021-02-01 12:56:45 PST
Committed r272169: <https://trac.webkit.org/changeset/272169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418896 [details].
Note You need to log in before you can comment on or make changes to this bug.