Bug 221140

Summary:

[LayoutTests] Convert http/tests/inspector/ convert PHP to Python

Product:

WebKit

Reporter:

Chris Gambrell <cgambrell>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220749

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Chris Gambrell

Reported 2021-01-29 09:44:26 PST

Replacing PHP with equivalent Python CGI scripts

Attachments
Patch (3.77 KB, patch) 2021-01-29 10:07 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (6.16 KB, patch) 2021-01-29 17:57 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (3.68 KB, patch) 2021-01-31 17:53 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (6.78 KB, patch) 2021-02-01 07:43 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (9.84 KB, patch) 2021-02-01 08:07 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (12.70 KB, patch) 2021-02-01 08:51 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (14.72 KB, patch) 2021-02-01 10:50 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (16.78 KB, patch) 2021-02-01 11:38 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (19.81 KB, patch) 2021-02-01 12:02 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (20.96 KB, patch) 2021-02-01 12:52 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (26.05 KB, patch) 2021-02-01 16:38 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (36.17 KB, patch) 2021-02-01 17:19 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (53.84 KB, patch) 2021-02-02 11:44 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (53.85 KB, patch) 2021-02-02 12:06 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (53.79 KB, patch) 2021-02-02 13:04 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (53.47 KB, patch) 2021-02-08 15:22 PST, Chris Gambrell	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (53.54 KB, patch) 2021-02-08 19:39 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (53.77 KB, patch) 2021-02-09 08:47 PST, Chris Gambrell	no flags	Details Formatted Diff Diff
Show Obsolete (17) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-01-29 09:46:04 PST

<rdar://problem/73758592>

Chris Gambrell

Comment 2 2021-01-29 10:07:45 PST

Created attachment 418744 [details] Patch

Chris Gambrell

Comment 3 2021-01-29 17:57:54 PST

Created attachment 418795 [details] Patch

Chris Gambrell

Comment 4 2021-01-31 17:53:22 PST

Created attachment 418837 [details] Patch

Chris Gambrell

Comment 5 2021-02-01 07:43:28 PST

Created attachment 418873 [details] Patch

Chris Gambrell

Comment 6 2021-02-01 08:07:10 PST

Created attachment 418875 [details] Patch

Chris Gambrell

Comment 7 2021-02-01 08:51:01 PST

Created attachment 418882 [details] Patch

Chris Gambrell

Comment 8 2021-02-01 10:50:57 PST

Created attachment 418898 [details] Patch

Chris Gambrell

Comment 9 2021-02-01 11:38:11 PST

Created attachment 418905 [details] Patch

Chris Gambrell

Comment 10 2021-02-01 12:02:23 PST

Created attachment 418909 [details] Patch

Chris Gambrell

Comment 11 2021-02-01 12:52:23 PST

Created attachment 418914 [details] Patch

Chris Gambrell

Comment 12 2021-02-01 16:38:59 PST

Created attachment 418938 [details] Patch

Chris Gambrell

Comment 13 2021-02-01 17:19:06 PST

Created attachment 418943 [details] Patch

Chris Gambrell

Comment 14 2021-02-02 11:44:30 PST

Created attachment 419042 [details] Patch

Chris Gambrell

Comment 15 2021-02-02 12:06:54 PST

Created attachment 419045 [details] Patch

Jonathan Bedard

Comment 16 2021-02-02 12:43:00 PST

Comment on attachment 419045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419045&action=review Before we land this change, we need to ensure all ports are ok with the change and ensure that this works on our Windows ports. > LayoutTests/http/tests/inspector/network/resources/basic-auth.py:9 > +expectedUsername = "goodUsername" Lets standardize on single quotes > LayoutTests/http/tests/inspector/network/resources/delay.py:16 > +time.sleep((delay * 1000) * 0.000001) This should just be time.sleep(delay / 1000) > LayoutTests/http/tests/inspector/network/resources/intercept-echo.py:21 > +ct = os.environ.get('CONTENT_TYPE') Let's use a better variable than 'ct', perhaps 'content_type'? > LayoutTests/http/tests/inspector/network/resources/intercept-echo.py:31 > +sys.stdout.write(' \"uri\": \"{}\",\n'.format(os.environ.get('REQUEST_URI'))) We shouldn't need to escape the "s in this string, since this string is using single quotes > LayoutTests/http/tests/inspector/network/resources/json.py:7 > +sys.stdout.write('{\"version\": 1}') We shouldn't need to escape the "s in this string, since this string is using single quotes

Chris Gambrell

Comment 17 2021-02-02 13:04:07 PST

Created attachment 419058 [details] Patch

Jonathan Bedard

Comment 18 2021-02-02 13:11:25 PST

Comment on attachment 419058 [details] Patch Change looks good! We aren't quite ready to land yet, though. We need to make sure all ports can run Python cgi tests before landing.

Chris Gambrell

Comment 19 2021-02-08 15:22:15 PST

Created attachment 419644 [details] Patch

Chris Gambrell

Comment 20 2021-02-08 16:03:41 PST

Some stylistic changes with multi-line sys.stdout.write's

Jonathan Bedard

Comment 21 2021-02-08 16:28:35 PST

Comment on attachment 419644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419644&action=review > LayoutTests/http/tests/inspector/network/resources/404.py:10 > + 'Content-Type: text/html\r\n' We need to replace tabs with spaces, but other than that, looks good.

Chris Gambrell

Comment 22 2021-02-08 19:39:45 PST

Created attachment 419670 [details] Patch

Chris Gambrell

Comment 23 2021-02-09 08:47:10 PST

Created attachment 419724 [details] Patch

EWS

Comment 24 2021-02-09 09:36:15 PST

Committed r272582: <https://commits.webkit.org/r272582> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419724 [details].

Note You need to log in before you can comment on or make changes to this bug.