Summary: | [LayoutTests] Convert http/tests/inspector/ convert PHP to Python | ||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Gambrell <cgambrell> | ||||||||||||||||||||||||||||||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220749 | ||||||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Chris Gambrell
2021-01-29 09:44:26 PST
Created attachment 418744 [details]
Patch
Created attachment 418795 [details]
Patch
Created attachment 418837 [details]
Patch
Created attachment 418873 [details]
Patch
Created attachment 418875 [details]
Patch
Created attachment 418882 [details]
Patch
Created attachment 418898 [details]
Patch
Created attachment 418905 [details]
Patch
Created attachment 418909 [details]
Patch
Created attachment 418914 [details]
Patch
Created attachment 418938 [details]
Patch
Created attachment 418943 [details]
Patch
Created attachment 419042 [details]
Patch
Created attachment 419045 [details]
Patch
Comment on attachment 419045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419045&action=review Before we land this change, we need to ensure all ports are ok with the change and ensure that this works on our Windows ports. > LayoutTests/http/tests/inspector/network/resources/basic-auth.py:9 > +expectedUsername = "goodUsername" Lets standardize on single quotes > LayoutTests/http/tests/inspector/network/resources/delay.py:16 > +time.sleep((delay * 1000) * 0.000001) This should just be time.sleep(delay / 1000) > LayoutTests/http/tests/inspector/network/resources/intercept-echo.py:21 > +ct = os.environ.get('CONTENT_TYPE') Let's use a better variable than 'ct', perhaps 'content_type'? > LayoutTests/http/tests/inspector/network/resources/intercept-echo.py:31 > +sys.stdout.write(' \"uri\": \"{}\",\n'.format(os.environ.get('REQUEST_URI'))) We shouldn't need to escape the "s in this string, since this string is using single quotes > LayoutTests/http/tests/inspector/network/resources/json.py:7 > +sys.stdout.write('{\"version\": 1}') We shouldn't need to escape the "s in this string, since this string is using single quotes Created attachment 419058 [details]
Patch
Comment on attachment 419058 [details]
Patch
Change looks good! We aren't quite ready to land yet, though. We need to make sure all ports can run Python cgi tests before landing.
Created attachment 419644 [details]
Patch
Some stylistic changes with multi-line sys.stdout.write's Comment on attachment 419644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419644&action=review > LayoutTests/http/tests/inspector/network/resources/404.py:10 > + 'Content-Type: text/html\r\n' We need to replace tabs with spaces, but other than that, looks good. Created attachment 419670 [details]
Patch
Created attachment 419724 [details]
Patch
Committed r272582: <https://commits.webkit.org/r272582> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419724 [details]. |