Bug 22112

Summary: if a <body> has contenteditable=true, it should report a writable AXValue
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch to make web areas have writable AXValue if contenteditable exists bdakin: review+

chris fleizach
Reported 2008-11-06 12:35:26 PST
This will allow assistive apps to know how to treat the web area
Attachments
patch to make web areas have writable AXValue if contenteditable exists (9.50 KB, patch)
2008-11-06 12:41 PST, chris fleizach 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2008-11-06 12:38:25 PST
*** Bug 22113 has been marked as a duplicate of this bug. ***
chris fleizach
Comment 2 2008-11-06 12:41:13 PST
Created attachment 24954 [details] patch to make web areas have writable AXValue if contenteditable exists
Beth Dakin
Comment 3 2008-11-06 13:58:34 PST
Comment on attachment 24954 [details] patch to make web areas have writable AXValue if contenteditable exists > Index: WebCore/page/AccessibilityRenderObject.cpp > =================================================================== > --- WebCore/page/AccessibilityRenderObject.cpp (revision 38190) > +++ WebCore/page/AccessibilityRenderObject.cpp (working copy) > @@ -341,6 +341,10 @@ bool AccessibilityRenderObject::isReadOn > if (!document) > return true; > > + HTMLElement *body = document->body(); > + if (body && body->isContentEditable()) > + return false; > + > Frame* frame = document->frame(); > if (!frame) > return true; You should move the star -- should be: HTMLElement* body =… > Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h > =================================================================== > --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h (revision 38190) > +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h (working copy) > @@ -69,8 +69,10 @@ public: > JSStringRef attributesOfDocumentLinks(); > JSStringRef attributesOfChildren(); > JSStringRef parameterizedAttributeNames(); > - > + You should fix this whitespace change. r=me
chris fleizach
Comment 4 2008-11-06 14:17:30 PST
http://trac.webkit.org/changeset/38200
Note You need to log in before you can comment on or make changes to this bug.